Changes between Initial Version and Version 1 of Ticket #16933


Ignore:
Timestamp:
Mar 28, 2013, 9:51:10 PM (6 years ago)
Author:
bill
Comment:

It's not a mistake, it's a requirement that the child widget have a focus() method. In dojo we prefer exceptions to code that fails silently. I don't know why that initial code about if(!widget){ return; } is there; it probably shouldn't be. I traced in back to [10466], where it came from Menu, but didn't trace farther than that.

I tried test_Menu.html and didn't see any error about MenuSeparator. If you have a test case that fails please attach a it using the "attach file" button. It should be as small as possible to still reproduce the problem, almost always a single HiML file that we can load in the browser (i.e. not PHP, JSP, etc.)

Then, give exact instructions on how to reproduce the problem using your attached test file.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #16933

    • Property Owner set to dbsalgad
    • Property Status changed from new to pending
    • Property Component changed from General to Dijit
  • Ticket #16933 – Description

    initial v1  
    11On line 167 of this module, there is a check for
    22
     3{{{
    34if(!widget){
    45    return;
    56}
     7}}}
    68
    79This should be changed to ensure that the widget also has a focus().
    810
     11{{{
    912if(!widget || typeof widget.focus != "function"){ return; }
     13}}}
    1014
    1115Otherwise you might encounter a bug like: "Uncaught TypeError: Object [Widget dijit.MenuSeparator, dijit_MenuSeparator_3] has no method 'focus'"