Opened 7 years ago

Closed 7 years ago

Last modified 5 years ago

#16926 closed defect (fixed)

test failures due to async focus() execution (IE9+)

Reported by: haysmark Owned by: haysmark
Priority: undecided Milestone: 1.7.6
Component: Dijit Version: 1.8.3
Keywords: Cc:
Blocked By: Blocking:

Description

In IE9 and 10 the robot TabContainer_a11y has some test issues with focus. A lot of tests use the pattern 1) focus, 2) set up focus handler, 3) do robot action to focus something else. But the problem in IE is that the focus call does not get invoked until after the thread is released, so the test fails because the handler detects the focus going to the first focused element.

Attachments (1)

16926.patch (1.5 KB) - added by haysmark 7 years ago.
Fix test issues in TabContainer_a11y in IE9 and IE10. Fixes #16926.

Download all attachments as: .zip

Change History (18)

Changed 7 years ago by haysmark

Attachment: 16926.patch added

Fix test issues in TabContainer_a11y in IE9 and IE10. Fixes #16926.

comment:1 Changed 7 years ago by haysmark

Owner: changed from bill to haysmark
Status: newassigned

comment:2 Changed 7 years ago by haysmark

Milestone: tbd1.9

comment:3 Changed 7 years ago by haysmark

Resolution: fixed
Status: assignedclosed

In [31028]:

Fix test issues in TabContainer_a11y in IE9 and IE10. Fixes #16926.

comment:4 Changed 7 years ago by bill

Summary: [patch] TabContainer_a11y test failure in IEtest failures due to async focus() execution (IE9+)

comment:5 Changed 7 years ago by bill

In [31076]:

fix spurious Dialog test failures on IE10 due to async focus(), refs #16926

comment:6 Changed 7 years ago by bill

In [31084]:

fix spurious _KeyNavContainer test failures on IE10 due to async focus(), refs #16926

comment:7 Changed 7 years ago by bill

In [31089]:

On IE9+ clicking a Button (with the mouse) to open a Dialog and then closing the Dialog doesn't refocus the Button, due to the async nature of the focus event. But I don't think we should be guaranteeing refocus except when the Dialog was opened via keyboard (tabbing to the Button and then pressing ENTER/SPACE). So changing the mouse test to not check for Dialog refocus. Refs #16926.

comment:8 Changed 7 years ago by bill

In [31106]:

allow for IE9+'s async focus in Form test, refs #11800

(but should have referenced this ticket)

comment:9 Changed 7 years ago by bill

In [31107]:

allow for IE9+ async focus in DateTextBox test, refs #16926

comment:10 Changed 7 years ago by bill

In [31118]:

allow for IE9+ async focus in test_validate test, refs #16926

comment:11 Changed 7 years ago by bill

In [31121]:

allow for IE9+ async focus in ComboBox and FilteringSelect test, refs #16926

comment:12 Changed 7 years ago by bill

In [31145]:

allow for IE9+ async focus in test_validate.html, refs #16926, #16964

comment:13 Changed 7 years ago by bill

In [31152]:

Use IE's native focusin/focusout support for IE9+ too, avoiding asynchronous focus notification, fixes #16968, #16970, and refs #16926, #16972 !strict.

comment:14 Changed 6 years ago by mahays0 <mahays0@…>

In b9ab7f580c8a123ff07ebd9a3b0695e24cf5c5ba/dojo:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:15 Changed 5 years ago by Bill Keese <bill@…>

In 715696a10a4654babf3fb872125127658ea728e4/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:16 Changed 5 years ago by bill

Milestone: 1.91.7.6

comment:17 Changed 5 years ago by Bill Keese <bill@…>

In 22e1395411ee81d1c6cd72bc08ef954591bb3563/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.