#16919 closed defect (fixed)
node version sniffing problem for >= 0.10
Reported by: | zzebastien | Owned by: | Kitson Kelly |
---|---|---|---|
Priority: | blocker | Milestone: | 1.7.5 |
Component: | BuildSystem | Version: | 1.8.3 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description (last modified by )
Hi, I found a bug in the Dojo Build System and node js v0.10.1
Error log report:
{ [Error: spawn EMFILE] code: 'EMFILE', errno: 'EMFILE', syscall: 'spawn' } Error: spawn EMFILE at errnoException (child_process.js:945:11) at ChildProcess.spawn (child_process.js:892:11) at exports.spawn (child_process.js:680:9) at .../src/util/build/node/process.js:25:16 at Object.release (.../src/util/build/fileHandleThrottle.js:9:20) at ChildProcess.finish (.../src/util/build/node/process.js:30:12) at ChildProcess.EventEmitter.emit (events.js:98:17) at Process.ChildProcess._handle.onexit (child_process.js:754:12)
The error is in the file process.js in src/util/build/node/ folder:
The condition check on version >=0.8 is wrong because the node version 0.10.1 is converted to 0.1.
var version = Number(process.version.match(/\d+\.\d+/)[0]) //will return 0.1 for node version 0.10.0 and will be considered as inferior as 0.8 :( ... if(version>=0.8){ process.on("close", finish); }else{ ++status; }
Thanks !
Change History (11)
comment:1 Changed 9 years ago by
Description: | modified (diff) |
---|---|
Summary: | BUildSystem → node version sniffing problem for >= 0.10 |
comment:4 Changed 9 years ago by
Milestone: | tbd → 1.9 |
---|
comment:5 Changed 9 years ago by
This needs backporting into 1.8 and 1.7. I can do it if no one minds.
comment:6 Changed 9 years ago by
Milestone: | 1.9 → 1.7.5 |
---|---|
Priority: | undecided → blocker |
Resolution: | fixed |
Status: | closed → reopened |
Backport, please.
comment:7 Changed 9 years ago by
Owner: | changed from Rawld Gill to Kitson Kelly |
---|---|
Status: | reopened → assigned |
comment:8 Changed 9 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
Confirmed that
Number("0.10.0".match(/\d+\.\d+/)[0])
returns 0.1, and that code is still there in trunk.