node version sniffing problem for >= 0.10

[zzebastien]

Hi, I found a bug in the Dojo Build System and node js v0.10.1

Error log report:

{ [Error: spawn EMFILE] code: 'EMFILE', errno: 'EMFILE', syscall: 'spawn' }
Error: spawn EMFILE
    at errnoException (child_process.js:945:11)
    at ChildProcess.spawn (child_process.js:892:11)
    at exports.spawn (child_process.js:680:9)
    at .../src/util/build/node/process.js:25:16
    at Object.release (.../src/util/build/fileHandleThrottle.js:9:20)
    at ChildProcess.finish (.../src/util/build/node/process.js:30:12)
    at ChildProcess.EventEmitter.emit (events.js:98:17)
    at Process.ChildProcess._handle.onexit (child_process.js:754:12)

The error is in the file process.js in src/util/build/node/ folder:

The condition check on version >=0.8 is wrong because the node version 0.10.1 is converted to 0.1.

var version = Number(process.version.match(/\d+\.\d+/)[0]) //will return 0.1 for node version 0.10.0 and will be considered as inferior as 0.8 :(
...
if(version>=0.8){
process.on("close", finish);
}else{
++status;
}

Thanks !

[bill]

Confirmed that Number("0.10.0".match(/\d+\.\d+/)[0]) returns 0.1, and that code is still there in trunk.

[Rawld Gill]

In [31266]:

fix node decoding bug; thanks zzebastien; fixes #16919; !strict

[Rawld Gill]

In [31267]:

remove debugging cruft improperly committed in [31266]; refs #16919; !strict

[Kitson Kelly]

This needs backporting into 1.8 and 1.7. I can do it if no one minds.

[Colin Snover]

Backport, please.

[Kitson Kelly <dojo@…>]

In b3605360d170650222dc621d26c47297a63be83f/util:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Kitson Kelly <dojo@…>]

In 6b4a45ca89d27e445d2409779effa8fde78d40dd/util:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Kitson Kelly <dojo@…>]

In 05ef9ff452c5718308052a0a7de3a36e974700c0/util:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

[Kitson Kelly <dojo@…>]

In dcbf8c71b2cd3b27af0f05e33e71105d7c385915/util:

Error: Processor CommitTicketReference failed

Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled?