#16900 closed defect (fixed)
[patch][ccla]dojox/gesture breaks the editing of input fields
| Reported by: | Adrian Vasiliu | Owned by: | Evan |
|---|---|---|---|
| Priority: | undecided | Milestone: | 1.9 |
| Component: | Dojox | Version: | 1.9.0a2 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
dojox/gesture breaks the editing of <input> (or <textarea>) elements that are descendants of elements for which dojox/gesture is used.
How to reproduce:
- Load the attached test_gesture_with_input_field.html (this is the same as dojox/gesture/tests/test_gesture.html except that it contains an <input> field).
- Try to edit the content of the input field (click or touch the input field).
=> You cannot.
This holds in both desktop (latest FF or Chrome) and mobile browsers (Safari on iPad 4). A workaround is (on desktop) to give the focus to the input field using the TAB key.
The cause is the e.preventDefault() called by dojox/gesture/Base._process() regardless of the type of event's target. The attached suggested patch goes similarly as dojo/touch for the same issue.
Attachments (2)
Change History (10)
Changed 8 years ago by
| Attachment: | test_gesture_with_input_field.html added |
|---|
Changed 8 years ago by
| Attachment: | patch16900.patch added |
|---|
Avoid breaking the editing of input fields - Adrian Vasiliu (IBM, CCLA)
comment:1 Changed 8 years ago by
comment:2 Changed 8 years ago by
| Owner: | changed from Adam Peller to Evan |
|---|---|
| Status: | new → assigned |
| Summary: | dojox/gesture breaks the editing of input fields → [patch][ccla]dojox/gesture breaks the editing of input fields |
comment:3 Changed 8 years ago by
Related ticket: #16676, which is also about the impact of this preventDefault(). Note that http://trac.dojotoolkit.org/attachment/ticket/16676/gesture_click.patch does not fix the issue reported in the present ticket, while the issue is still fixed by applying both patches (no conflict).
comment:5 Changed 8 years ago by
(Committed after getting green light from Evan who wrote me "The fix looks safe and reasonable, please feel free to commit after you tested.". Testing: found no regression due to this change).
comment:6 Changed 8 years ago by
Further change committed with log containing wrong id in "refs", sorry. See [31238].
comment:7 Changed 6 years ago by
| Milestone: | tbd → 1.9 |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
Looks like this was fixed 3 years ago. Closing it out.
Test case to reproduce that issue.