Opened 7 years ago

Closed 7 years ago

#16877 closed defect (fixed)

[PATCH][CCLA] dijit.form._AutoCompleterMixin invalid use of aria-activedescendant

Reported by: mikeb Owned by: Douglas Hays
Priority: undecided Milestone: 1.8.4
Component: Dijit - Form Version: 1.8.3
Keywords: Cc:
Blocked By: Blocking:

Description

dijit.form._AutoCompleterMixin correctly uses aria-activedescendant attribute to signify to the screen reader what option in a drop down is selected. However, when the drop down is closed and the domNode is no longer visible, this attribute should be removed but it is not. There is code in closeDropDown() to remove this attribute, but we call closeDropDown first and then later the a11y code to set aria-activedescendant, so we had to move this call to remove the attribute a little later.

Attached a patch for the nightly build and for 1.8 - can we please backport this to maintain accessibility support on 1.8? Thanks.

Attachments (2)

nightly_a11y_aria-activedescendant_AutoCompleterMixin.js.patch (1.4 KB) - added by mikeb 7 years ago.
dijit.form._autoCompleterMixin - correctly remove aria-activedescendant attribute, please proxy commit for Michael Billau, CCLA on file with IBM
1.8_a11y_aria-activedescendant_AutoCompleterMixin.patch (1.3 KB) - added by mikeb 7 years ago.
dijit.form._autoCompleterMixin - correctly remove aria-activedescendant attribute on 1.8 stream, please proxy commit for Michael Billau, CCLA on file with IBM

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by mikeb

dijit.form._autoCompleterMixin - correctly remove aria-activedescendant attribute, please proxy commit for Michael Billau, CCLA on file with IBM

Changed 7 years ago by mikeb

dijit.form._autoCompleterMixin - correctly remove aria-activedescendant attribute on 1.8 stream, please proxy commit for Michael Billau, CCLA on file with IBM

comment:1 Changed 7 years ago by mikeb

Whoops, I accidentally saved the second patch as .js, reuploaded it but can't remove the bad link.

comment:2 Changed 7 years ago by Douglas Hays

Milestone: tbd1.9
Status: newassigned

comment:3 Changed 7 years ago by Douglas Hays

Milestone: 1.91.8.4

comment:4 Changed 7 years ago by Douglas Hays

Resolution: fixed
Status: assignedclosed

In [30940]:

Fixes #16877. Proxy commit for mikeb. Remove aria-activedescendant after ComboBox? dropdown closes.

Note: See TracTickets for help on using tickets.