Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#16862 closed defect (fixed)

[PATCH][CCLA] dojox.form.Uploader - uploader needs accessibility update

Reported by: mikeb Owned by: Mike Wilcox
Priority: undecided Milestone: 1.9
Component: DojoX Uploader Version: 1.8.3
Keywords: Cc: bill
Blocked By: Blocking:

Description

Dojox.form.uploader is missing a few accessibility attributes and is being flagged as a violation.

Attached a patch that updates the uploader and the associated test pages.

Changes were pretty simple, just adding role="presentation" to the hidden form objects, and connecting the focusNode to the label via aria-labelledby.

I also attached a patch for 1.8 - could we please backport this to 1.8 in order to keep that stream fully accessible? (wait, should I create a 1.9 patch now too?)

Attachments (2)

dojox.form.Uploader a11y fixes.patch (7.8 KB) - added by mikeb 7 years ago.
Fix dojox.form.Uploader's accessibility, patch for nightly stream, please proxy commit for Michael Billau, CCLA with IBM
1.8.dojox.form.Uploader a11y fixes.patch (7.1 KB) - added by mikeb 7 years ago.
Fix dojox.form.Uploader's accessibility, patch for 1.8 stream, please proxy commit for Michael Billau, CCLA with IBM

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by bill

Component: GeneralDojoX Uploader
Owner: set to Mike Wilcox

There's no branch for 1.9 yet, so patch against trunk is fine. (I see you haven't actually attached the patches yet though, did you forget?)

Changed 7 years ago by mikeb

Fix dojox.form.Uploader's accessibility, patch for nightly stream, please proxy commit for Michael Billau, CCLA with IBM

Changed 7 years ago by mikeb

Fix dojox.form.Uploader's accessibility, patch for 1.8 stream, please proxy commit for Michael Billau, CCLA with IBM

comment:2 Changed 7 years ago by mikeb

Cc: bill added
Milestone: tbd1.9

comment:3 Changed 7 years ago by Mike Wilcox

Resolution: fixed
Status: newclosed

In [30878]:

Fixes #16862 - added aria to Uploader

comment:4 Changed 7 years ago by Mike Wilcox

The patch was out of date, as it didn't account for my changes yesterday. But they seemed simple enough so I applied them manually.

comment:5 Changed 7 years ago by mikeb

Hey Mike, thanks for applying the changes. You missed a small change to test_Uploader_programmatic.html page, the div at the top also needs to be renamed "parentdiv": http://archive.dojotoolkit.org/nightly/dojotoolkit/dojox/form/tests/test_Uploader_programmatic.html

Thanks - do you think we could also apply this to 1.8 for support purposes? I can ask somebody else to backport if you'd like.

Note: See TracTickets for help on using tickets.