Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#16852 closed defect (fixed)

Custom boot layer "bootText" property ignored.

Reported by: Matt Senter Owned by: Rawld Gill
Priority: undecided Milestone: 1.9
Component: BuildSystem Version: 1.8.3
Keywords: Cc:
Blocked By: Blocking:

Description

I have a need to include custom bootText on a per-layer basis, and it looks like there is an undocumented feature that does just that, but it does not work. When looking for issues regarding the build (I have others,) I found this:

http://trac.dojotoolkit.org/ticket/15856#comment:17

rcgill mentions supplying a layer level bootText value. This would be perfect for me as I want to have a single profile to build multiple boot layers, each with its own startup dependency. I looked at the source, and sure enough, there is a place in writeDojo.js that is supposed to account for this layer-level bootText:

// Line 154
item.layerText= loaderText + configText + dojoLayerText + writeAmd.getLayerText(item, false) + (item.bootText || bc.dojoBootText || dojoBootText) + dojoLayerCompat + compat;

That line references item.bootText. However, supplying this property does nothing. Instead, I believe the correct code should be item.layer.bootText, should it not? All of the other layer-level properties are referenced via item.layer, such as item.layer.include. And indeed, we have in discover.js:

// Line 313
resource.layer = layer;

In this case resource is analagous to item from above. Or am I reading it incorrectly?

Ultimately, the current code does not work. I could provide a simple test case, but I think it may be unnecessary since I have provided the solution. =)

Change History (2)

comment:1 Changed 6 years ago by Rawld Gill

Resolution: fixed
Status: newclosed

In [30929]:

fix typo in code; fixes #16852; thanks mrfu; !strict

comment:2 Changed 6 years ago by bill

Milestone: tbd1.9
Note: See TracTickets for help on using tickets.