[patch][cla] make createSubclass() mixins parameter optional

[ben hockey]

since the base class is implied in createSubclass it should work without providing mixins.

SomeClass.createSubclass({ ... }); // should work

SomeClass.createSubclass([], { ... }); // the current workaround

[bill]

Would be nice, although you could also argue that declare({ ... }) should work, rather than declare([], { ... }).

[Bryan Forbes]

That's true, however createSubclass(null, {}) doesn't even work, so it's not matching declare anyway.

[DevShaft]

Here by I want to contribute a patch for this issue. Basically the mixins parameter is made optional same way as in the declare function. I think an extra test case is not needed for this issue. Let me know if you need anything.

EDIT: Ignore the attachment, was the wrong file. See here for patch: ​https://github.com/DevShaft/dojo/commit/9aab83215fb7190ff7f98ba6c2c38275c24c80f9.patch

[cjolif]

Hi DevShaft?,

Thanks for your contribution. A few things however:

1/ you need to sign a Dojo CLA to contribute see ​http://dojofoundation.org/about/cla. Have you signed one? 2/ having a test would be good. Especially that this should be easy by just extending the current createSubclass tests with this? 3/ once 1/ and 2/ are done I suggest submitting your patch as a github pull request as this is the new way to proceed (see ​https://github.com/dojo/dojo/blob/master/CONTRIBUTING.md)

[DevShaft]

Hi cjolif, thanks for your reply. Yes, I have 1/ and will do 2/ and 3/.

[bill]

Looks like ​https://github.com/dojo/dojo/pull/46 has a test case (and the fix).

[cjolif]

thanks bill, so if nobody has objections I'm going to merge this as I own the ticket.

[bill]

sounds good to me

[dylan]

ok with me.

[bill]

Was pushed in d4d8cc718873da37d8026ab8b24065074ed34b2f.