Opened 6 years ago

Closed 6 years ago

#16847 closed defect (fixed)

dijit/form/select - missing css reset

Reported by: Samuel Ondrek Owned by: Douglas Hays
Priority: undecided Milestone: 1.9
Component: Dijit - Form Version: 1.8.3
Keywords: Cc:
Blocked By: Blocking:

Description

Hello,

WTF:

Standard dijit/form/select works fine:
#http://jsfiddle.net/ondrek/MMKdL/ (sample without normalize.css)

But, if we use "normalize.css" or any better "css resets",
we get a new bug with missing border on selectable part
#http://jsfiddle.net/ondrek/MMKdL/3/ (sample with normalize.css)

You can fix this with css rule:
#http://jsfiddle.net/ondrek/MMKdL/4/ (fixed sample with normalize.css)

.dijitSelect { border-collapse: separate; }

REASON:

Your dijitReset is missing: {border-collapse: separate;}
You can implement this in .dijitSelect, also

WHY:

Your CSS resets are not perfect, so we need to use
external resets, which are not compatibile with dijit.

Change History (2)

comment:1 Changed 6 years ago by bill

Milestone: tbd1.9

Looks trivial, might as well put into 1.9.

comment:2 Changed 6 years ago by Douglas Hays

Resolution: fixed
Status: newclosed

In [30963]:

Fixes #16847. Add border-collapse css to work around jsfiddle css overrides.

Note: See TracTickets for help on using tickets.