Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#16834 closed defect (fixed)

[patch][ccla]The dojo build css optimizer may report wrong errors when image file uri contains extra request parameters

Reported by: Patrick Ruzand Owned by: Rawld Gill
Priority: undecided Milestone: 1.8.4
Component: BuildSystem Version: 1.8.3
Keywords: Cc:
Blocked By: Blocking:

Description

If a css contains URLs containing request parameters, the build system fails to properly resolve the resource path when processing urls of imported css. For example:

url("./foo/bar.abc?something=2)

the css optimizer looks for the file "bar.abc?something=2" and fails to locate it. Instead, it should filter the url request parameters.

The proposed patch filters the request parameters part so that the resource path can be properly resolved.

Attachments (1)

16834.patch (1.4 KB) - added by Patrick Ruzand 7 years ago.
patch by pruzand (IBM, CCLA)

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by Patrick Ruzand

Attachment: 16834.patch added

patch by pruzand (IBM, CCLA)

comment:1 Changed 7 years ago by Patrick Ruzand

Milestone: tbd1.9

comment:2 Changed 7 years ago by Rawld Gill

Status: newassigned

comment:3 Changed 7 years ago by Rawld Gill

Resolution: fixed
Status: assignedclosed

In [31254]:

improved CSS optimize transform to allow for query params in URLs mentioned in CSS; thanks pruzand; fixes #16834; !strict

comment:4 Changed 6 years ago by Patrick Ruzand

Hi Ralwd,

could this fix be backported to 1.8 branch ? Technically, it seems the patch can be applied as is without any conflicts.

comment:5 Changed 6 years ago by Patrick Ruzand <pruzand@…>

In 324b4ed24cbdb777f2410f3fe2a7865131913b07/util:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 

comment:6 Changed 6 years ago by Patrick Ruzand

Milestone: 1.91.8.4
Note: See TracTickets for help on using tickets.