Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#16813 closed defect (fixed)

REGRESSION: Errors in parsing in dojo.html.parse no longer call _onError

Reported by: Jared Jurkiewicz Owned by: bill
Priority: undecided Milestone: 1.8.4
Component: Dijit Version: 1.8.3
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by Jared Jurkiewicz)

This came up in our applications that if the basic content parser in dojo/html.js encountered an error when parsing the content, that it no longer called the _onError function because it isn't passing the error callback to the promise.then() call. This breaks some error flow in dijit.layout.ContentPane?

This is fairly simple to fix. Patch coming.

Attachments (1)

16813.patch (472 bytes) - added by Jared Jurkiewicz 6 years ago.
Simple patch for this to include error callback.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 6 years ago by Jared Jurkiewicz

Summary: Errors in parsing in dojo.html.parse no longer call this._onErrorREGRESSION: Errors in parsing in dojo.html.parse no longer call _onError

Changed 6 years ago by Jared Jurkiewicz

Attachment: 16813.patch added

Simple patch for this to include error callback.

comment:2 Changed 6 years ago by Jared Jurkiewicz

Description: modified (diff)

comment:3 Changed 6 years ago by bill

Milestone: tbd1.8.4
Status: newassigned

Regression from [28465]? OK, makes sense.

comment:4 Changed 6 years ago by bill

Resolution: fixed
Status: assignedclosed

In [30787]:

fix regression from [28465] where errors don't get reported, fixes #16813 and refs #15118, #14591 on 1.8/ branch, thanks Jared, !strict.

comment:38 Changed 6 years ago by bill

In [30788]:

fix regression from [28465] where errors don't get reported, fixes #16813 and refs #15118, #14591 on trunk/, thanks Jared, !strict.

Note: See TracTickets for help on using tickets.