#16798 closed defect (fixed)
[regression] dojox/form/CheckedMultiSelect doesn't change value on click
Reported by: | lzboron | Owned by: | bill |
---|---|---|---|
Priority: | undecided | Milestone: | 1.9 |
Component: | Dijit | Version: | 1.8.3 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description (last modified by )
When I click on item in CheckedMultiSelect, its value is not changed.
This was broken with commit [30465] in dijit on Jan 27.
This commit changed binding events defined through 'data-dojo-attach-event'. It replaced old dojo.connect with dojo.on, but 'dojox/form/resources/_CheckedMultiSelectItem.html' contains
data-dojo-attach-event="_onClick:_changeBox"
'_onClick' doeesn't start with 'on' and so it is not correctly bound and CheckedMultiSelect then doesn't respond to click events.
Change History (4)
comment:1 Changed 9 years ago by
Component: | DojoX Form → Dijit |
---|---|
Description: | modified (diff) |
Owner: | changed from dante to bill |
Status: | new → assigned |
comment:2 Changed 9 years ago by
Milestone: | tbd → 1.9 |
---|---|
Summary: | dojox/form/CheckedMultiSelect doesn't change value on click → [regression] dojox/form/CheckedMultiSelect doesn't change value on click |
Note: See
TracTickets for help on using
tickets.
Updating description from https://github.com/dojo/dijit/commit/ea9f51c2d879cc2f31cb868eb060d62a044cd05b to [30465].
Sounds like I broke something; I didn't think about connecting to events on widgets (as opposed to DOMNodes) and apparently dijit doesn't have tests for that either.