[regression] dojox/form/Uploader.upload optional parameter

[lzboron]

According to documentation and comments function 'upload' of dojox/form/Uploader has one optional parameter 'formData', but it contains this code:

formData.uploadType = this.uploadType;

Also function 'uploadIFrame' in 'uploader/_IFrame.js' and function 'uploadFlash' in 'uploader/_Flash.js' contain similar code, which fails, when no parameter is provided.

Older versions of Uploader (1.7) did not require this parameter.

[dylan]

This one looks like a fairly strong regression.

[Mike Wilcox]

In [30850]:

Fixes #16796

[lzboron]

I do not think this is fixed. I upload files programatically by calling upload function on uploader. This function looks like this:

//Uploader.js
upload: function(/*Object?*/ formData){				
	// summary:
	//	When called, begins file upload. Only supported with plugins.
	formData.uploadType = this.uploadType;
	this.inherited(arguments);
},
//_Flash.js
uploadFlash: function(/*Object ? */ formData){
	// summary:
	//	Uploads selected files. Alias "upload()" should be used instead.
	// tags:
	//	private
	this.onBegin(this.getFileList());
	formData.returnType = "F";
	formData.uploadType = this.uploadType;
	console.log('flas upload', formData);
	this.flashMovie.doUpload(formData);
},
//_IFrame.js
uploadIFrame: function(data){
	// summary:
	//		Internal. You could use this, but you should use upload() or submit();
	//		which can also handle the post data.
	
	var
		formObject = {},
		sendForm,
		form = this.getForm(),
		url = this.getUrl(),
		self = this;
			
	data.uploadType = this.uploadType;
...
}

All these functions will fail if no formData is provided.

You can also see test dojox/form/tests/test_Uploader_programmatic.html. Click upload button in dialog and you will get error.

[Mike Wilcox]

In [30864]:

Fixes #16796 - ensuring forData object

[Mike Wilcox]

Ok, it wasn't clear what you were asking for. I think this fixes it.

[lzboron]

Thank you for fix, it works well for HTML5 upload. Same check should be added to IFrame and Flash plugins, because they override Uploader's upload function with their uploadIFrame and uploadFlash functions.

[bill]

Reopening to get fix in plugins (assuming above comment is valid).

[dylan]

In [31125]:

fixes #16796, make sure IFrame and Flash plugins don't break if data is not provided