Opened 6 years ago

Last modified 3 years ago

#16795 assigned enhancement

[patch] dojox/mobile/parser

Reported by: mm Owned by: Patrick Ruzand
Priority: low Milestone: 1.15
Component: DojoX Mobile Version: 1.8.3
Keywords: Cc:
Blocked By: Blocking:

Description

Existng:

mixin = mixin || {};

options = options || {};

if avoiding useless assignment (4 extra bytes sorry):

mixin || (mixin = {});
options || (options = {});

Also IMHO:

lang.mixin(params, _eval.call(options.propsThis, '({'+(n.getAttribute("data-dojo-props")||"")+'})'));
lang.mixin(params, options.defaults);
lang.mixin(params, mixin); 

Could be rewritten to mixni with multiple sources:

lang.mixin(params,a,b,c) 

saving 2 extra calls and making code shorter

Change History (8)

comment:1 Changed 6 years ago by mm

sorry, motivation about first is speed which tested on mobile, is 30% faster (on iOs browsers) without useless asignment.

comment:2 Changed 6 years ago by mm

For useless asignment see: http://jsperf.com/various-strange-syntaxes/6

another hint: http://jsperf.com/convert-to-number1/5

convenrt to number with unary +v instead o v-0 (saves 1 byte ;-)) and substract zero is slower (10-12%).

Last edited 6 years ago by mm (previous) (diff)

comment:3 Changed 6 years ago by cjolif

Component: GeneralDojoX Mobile
Owner: set to Eric Durocher

comment:4 Changed 6 years ago by dylan

Milestone: tbd1.10
Priority: undecidedlow

comment:5 Changed 6 years ago by Patrick Ruzand

Owner: changed from Eric Durocher to Patrick Ruzand
Status: newassigned

comment:6 Changed 5 years ago by Patrick Ruzand

Milestone: 1.10future

comment:7 Changed 3 years ago by dylan

Milestone: future1.12
Summary: dojox/mobile/parser[patch] dojox/mobile/parser

worth considering for 1.12 if you care about the speed of the mobile parser.

comment:8 Changed 3 years ago by dylan

Milestone: 1.131.15

Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.

Note: See TracTickets for help on using tickets.