Opened 8 years ago
Closed 8 years ago
#16790 closed defect (fixed)
dijit/Dialog error when duration is set to 0
Reported by: | lzboron | Owned by: | bill |
---|---|---|---|
Priority: | undecided | Milestone: | 1.9 |
Component: | Dijit | Version: | 1.8.3 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
When I show or hide dijit/Dialog with duration property set to 0, I get following error:
Uncaught TypeError: Cannot read property 'promise' of undefined
This error occurs on line 442 in dijit/Dialog.js. this._fadeOutDeferred is deleted in onEnd callback of fadeOut animation, which usually occurs later than this._fadeOutDeferred.promise is returned from hide function. But if you set duration to 0 (or set breakpoints to correct places), onEnd callback is called before hide function tries to read this._fadeOutDeferred.promise.
Note: See
TracTickets for help on using
tickets.
Agreed, good catch, thanks, I will check that change in.