dojo/request/node request: timer not handled on cancel()

[w3dman]

When using the dojo/request/node xhr with a timeout specified, and the request is cancelled (before the timer triggers), an uncaught exception can occur, and the node process will not exit until the timer finally triggers.

Script where behaviour is noted:

// node-xhr-test.js
require(["dojo/request/node"], function(xhr) {
  
  var request = xhr("http://dojotoolkit.org", {
    timeout: 30000
  });

  request.then(function(response) {
    console.log("Good!");
  }, function(err) {
    // this is triggered, but the process will hang
    // for the 'timeout' period
    console.log("Cancelled/Rejected: but the timer is still pending");
  });

  request.cancel();
 
});

// dojoConfig.js
dojoConfig = {
  async: true,
  baseUrl: ".",
  packages: [{
    name: "dojo",
    location: "dojo/dojo"
  }]
};
require("./dojo/dojo/dojo.js");

Run with: node dojoConfig.js load=node-xhr-test.js

Node.js (v0.8.15) will print the exception to the console and will not exit until the request timer has been triggered.

[w3dman]

Had a conversation with kitsonk about this issue on the #dojo IRC channel. I don't seen to be able to add him to the CC list.

[dylan]

Unfortunately need to defer to 1.12 without a PR.

[dylan]

Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.