Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#16771 closed defect (fixed)

dojox/mobile/ToolBarButton: wrong rendering when used only with arrow (no label), or with arrow plus icon plus label

Reported by: Adrian Vasiliu Owned by: Eric Durocher
Priority: undecided Milestone: 1.8.4
Component: DojoX Mobile Version: 1.8.3
Keywords: Cc:
Blocked By: Blocking:

Description

The rendering of dojox/mobile/ToolBarButton is wrong in the following 2 cases:

a) Button with only the arrow property set.

or

b) Button with arrow, icon and label properties set.

How to reproduce:

  1. Run the modified version of dojox/mobile/tests/test_Heading.html included in the attached patch.
  1. Check the rendering of the buttons inside the last 4 headings at the bottom of the page (heading's label clarifies the use-case for each button).

==> Buttons with arrow but no label are rendered as a diamond instead of the usual arrow on the left or right side of a rectangle. Buttons with arrow plus icon plus label are rendered with the rectangular part covering the arrow.

Attachments (1)

patch16771.patch (12.0 KB) - added by Adrian Vasiliu 7 years ago.
Now renders correctly when used only with arrow (no label), or with arrow plus icon plus label - Adrian Vasiliu (IBM, CCLA)

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by Adrian Vasiliu

Attachment: patch16771.patch added

Now renders correctly when used only with arrow (no label), or with arrow plus icon plus label - Adrian Vasiliu (IBM, CCLA)

comment:1 Changed 7 years ago by cjolif

Milestone: tbd1.8.4

comment:2 Changed 7 years ago by cjolif

In [30727]:

refs #16771. Now renders correctly when used only with arrow (no label), or with arrow plus icon plus label. Thanks Adrian Vasiliu (IBM, CCLA)

comment:3 Changed 7 years ago by cjolif

Resolution: fixed
Status: newclosed

In [30728]:

fixes #16771. Now renders correctly when used only with arrow (no label), or with arrow plus icon plus label. Thanks Adrian Vasiliu (IBM, CCLA)

comment:4 Changed 7 years ago by cjolif

In [30729]:

refs #16771. Small tests updates. Thanks Adrian Vasiliu (IBM, CCLA).

comment:5 Changed 7 years ago by cjolif

In [30730]:

refs #16771. Small tests updates. Thanks Adrian Vasiliu (IBM, CCLA).

Note: See TracTickets for help on using tickets.