#16770 closed feature (fixed)
BorderContainer: extend LayoutContainer
Reported by: | Wouter Hager | Owned by: | bill |
---|---|---|---|
Priority: | undecided | Milestone: | 1.9 |
Component: | Dijit | Version: | 1.9.0a1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description (last modified by )
Since AMD it would be proper to extend BorderContainer from a basic LayoutContainer that has the same features and API, but doesn't need the modules for gutters and splitters.
Change History (12)
comment:1 Changed 8 years ago by
Description: | modified (diff) |
---|---|
Summary: | Create base layout container like BorderContainer → BorderContainer: extend LayoutContainer |
comment:4 Changed 8 years ago by
Milestone: | tbd → 1.9 |
---|
comment:6 follow-ups: 7 8 Changed 8 years ago by
http://bugs.dojotoolkit.org/browser/dojo/dijit/trunk/layout/LayoutContainer.js?rev=30767#L22 mentions splitters - is that a doc typo?
comment:7 Changed 8 years ago by
Replying to neonstalwart:
http://bugs.dojotoolkit.org/browser/dojo/dijit/trunk/layout/LayoutContainer.js?rev=30767#L22 mentions splitters - is that a doc typo?
Probably, it's not in any dependencies.
comment:8 Changed 8 years ago by
Replying to neonstalwart:
http://bugs.dojotoolkit.org/browser/dojo/dijit/trunk/layout/LayoutContainer.js?rev=30767#L22 mentions splitters - is that a doc typo?
Ah right, cut-and-paste error, thanks.
comment:10 Changed 8 years ago by
BTW (regarding the ticket description), this actually has nothing to do with AMD.
Although BorderContainer isn't a subclass of LayoutContainer, they do share the layout code, which is in dijit/layout/utils::layoutChildren(). That's why LayoutContainer.js is a trivially small file.
Probably BorderContainer extending LayoutContainer makes sense. Is there some specific reason you wanted this? IIRC it wouldn't actually change the API or have any practical effect on applications.