BorderContainer: extend LayoutContainer

[Wouter Hager]

Since AMD it would be proper to extend BorderContainer from a basic LayoutContainer that has the same features and API, but doesn't need the modules for gutters and splitters.

[bill]

Although BorderContainer isn't a subclass of LayoutContainer, they do share the layout code, which is in dijit/layout/utils::layoutChildren(). That's why LayoutContainer.js is a trivially small file.

Probably BorderContainer extending LayoutContainer makes sense. Is there some specific reason you wanted this? IIRC it wouldn't actually change the API or have any practical effect on applications.

[bill]

In [30765]:

Undeprecate (precate?) the LayoutContainer code, and make BorderContainer extend LayoutContainer. Fixes #16770 !strict. Will add reference doc too.

[bill]

In [30766]:

Handle "leading" and "trailing" regions in LayoutContainer rather than BorderContainer. Also handle setting of classes on children widgets there. Refs #16770 !strict.

[bill]

In [30767]:

avoid spurious error about region being undefined, refs #16770

[ben hockey]

​http://bugs.dojotoolkit.org/browser/dojo/dijit/trunk/layout/LayoutContainer.js?rev=30767#L22 mentions splitters - is that a doc typo?

[Wouter Hager]

Replying to neonstalwart:

​http://bugs.dojotoolkit.org/browser/dojo/dijit/trunk/layout/LayoutContainer.js?rev=30767#L22 mentions splitters - is that a doc typo?

Probably, it's not in any dependencies.

[bill]

Replying to neonstalwart:

​http://bugs.dojotoolkit.org/browser/dojo/dijit/trunk/layout/LayoutContainer.js?rev=30767#L22 mentions splitters - is that a doc typo?

Ah right, cut-and-paste error, thanks.

[bill]

In [30777]:

fix cut-and-paste error in doc, refs #16770 !strict

[bill]

BTW (regarding the ticket description), this actually has nothing to do with AMD.

[bill]

In [31173]:

Add tests for LayoutContainer's new API: LayoutContainer.design and children using region and layoutPriority. Note that for backwards compatibility, "design" shouldn't affect children that set layoutAlign instead of region. This is basically "accidentally" working due to the way _getOrderedChildren() happens to be written. Refs #16770 !strict.

Also convert uses of deprecated layoutAlign in calls to utils.layoutChildren() to region, refs #16585 !strict.

[bill]

In [31174]:

revert unintended change from [31173], refs #16770 !strict.