SpinWheelSlot::set("value") can fail when browser zoom is != 100%

[Eric Durocher]

To reproduce the problem, save the attached test case to dojox/mobile/tests, launch in Chrome, zoom to 110% (one mouse wheel tick from 100%), reload: the picker should display Jan-1-2020, but it displays the current date instead.

The SpinWheelSlot::spin method assumes integer values for the current scroll position of the slot and tests for multiples of the item height, but when the browser zoom is set to e.g. 110%, the gePos() method can return decimal values, causing the slot to return prematurely at line 333.

[Eric Durocher]

Test case for SpinWheelSlot::spin bug with browser zoom != 100%

[Eric Durocher]

Round scroll position before testing for multiple of item height, fixes set("value") sometimes failing with browser zoom != 100% - Eric Durocher (IBM, CCLA)

[cjolif]

In [30722]:

fixes #16766. Round scroll position before testing for multiple of item height, fixes set(value) sometimes failing with browser zoom != 100%. Thanks Eric Durocher (IBM, CCLA).

[Eric Durocher]

Seems there are still cases when this fails -> reopening

[Adrian Vasiliu]

Improved behavior in presence of browser zoom - Adrian Vasiliu (IBM, CCLA)

[cjolif]

I'll be committing this but I don't think deleting the properties make sense in this case. These are properties that will be used regularly during the life of the component we should just set them back & forth to true/false (this allows JavaScript? VMs to optimize the class also to not add/delete fields regularly). I'll do the change myself.

[cjolif]

In [30782]:

fixes #16766. Improved the fix in presence of browser zoom. Thanks Adrian Vasiliu (IBM, CCLA) (with some changes). !strict.

[Adrian Vasiliu]

Fixes in test to ensure it works on any OS lang and also in IE8 - thanks edchat (IBM, CCLA)

[Ed Chatelain]

In [30961]:

refs #16766 Fixes in test to ensure it works on any OS lang and also in IE8 !strict