Opened 8 years ago
Closed 5 years ago
#16760 closed enhancement (patchwelcome)
Opener should dynamically adapt to the screen size
Reported by: | Eric Durocher | Owned by: | Patrick Ruzand |
---|---|---|---|
Priority: | undecided | Milestone: | 1.13 |
Component: | DojoX Mobile | Version: | 1.8.3 |
Keywords: | Cc: | Chris Mitchell, cjolif | |
Blocked By: | Blocking: |
Description (last modified by )
Currently the Opener widget is defined statically as a subclass of either Overlay (if the screen is small e.g. a phone) or Tooltip (if the screen is large e.g. a table). This means that, even if the screen size changes (e.g. on desktop), the Opener will always stay what it was according to the window size when the application started.
Instead, it would be nice if the Opener could choose dynamically between Overlay or Tooltip depending on the screen size every time show() is called.
Change History (7)
comment:1 Changed 8 years ago by
Cc: | Chris Mitchell cjolif added |
---|
comment:2 Changed 8 years ago by
Description: | modified (diff) |
---|
comment:3 Changed 8 years ago by
comment:4 Changed 8 years ago by
Type: | defect → enhancement |
---|
comment:5 Changed 8 years ago by
Owner: | changed from Eric Durocher to Patrick Ruzand |
---|---|
Status: | new → assigned |
comment:6 Changed 5 years ago by
Milestone: | tbd → 1.12 |
---|
comment:7 Changed 5 years ago by
Resolution: | → patchwelcome |
---|---|
Status: | assigned → closed |
Given that no one has shown interest in creating a patch in the past 2+ years, I'm closing this as patchwelcome.
Note: See
TracTickets for help on using
tickets.
To be usable in responsive design with media query, the Opener needs to choose dynamically between Overlay or Tooltip instance depending on the screen size when show() is called and when media query transitions move between tablet and phone screen dimensions. eg. if the opener is shown in tablet mode, and the browser is resized to phone mode, the overlay should appear (as if it's in phone mode) and the Tooltip should be hidden. Similarly, if in phone screen size with overlay showing, and browser is resized to tablet/desktop screen size (css media query) the tablet/desktop media query will display the hidden opener tooltip and hide the overlay from the phone size. CSS should be used for the hide/show, as js layout here results in flicker and artifacts that affect ux.