Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#16756 closed task (fixed)

multiple calls to iframe._loadFunc when in StackContainer (webkit)

Reported by: bill Owned by: bill
Priority: undecided Milestone: 1.9
Component: Editor Version: 1.8.3
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

_loadFunc() for the iframe (i.e. iframe.onLoad) is called twice, at least in themeTester.html on chrome and safari, mac and windows. Not sure what problems that causes besides spurious warnings about the RichText.onLoadDeferred being already resolved, but should probably put in guard code.

Doesn't happen on Firefox or IE9. But on webkit, it's called twice, each time with a new (but valid) window object.

Change History (5)

comment:1 Changed 6 years ago by bill

Milestone: tbd → 1.9
Owner: set to bill
Status: new → assigned

comment:2 Changed 6 years ago by bill

Description: modified (diff)
Summary: multiple calls to iframe._loadFunc → multiple calls to iframe._loadFunc (webkit)

comment:3 Changed 6 years ago by bill

Summary: multiple calls to iframe._loadFunc (webkit) → multiple calls to iframe._loadFunc when in StackContainer (webkit)

Started in [29904] with change to StackContainer.js. Apparently StackContainer._setupChild(), which mucks with the DOM, occurs after the Editor has been initialized, and Editor doesn't like that.

comment:4 Changed 6 years ago by bill

Resolution: → fixed
Status: assigned → closed

In [30677]:

Move this.open() call from postCreate() to startup(). Fixes problem with double call to iframe's onload method when StackContainer._setupChild() messes around with the DOM. Also probably allows Editor creation without specifying a srcNodeRef. It does require calling Editor.startup() though. Refs #16244 ([29904]), fixes #16756 !strict.

comment:21 Changed 6 years ago by bill

In [31183]:

Editor needs startup() call, fixes #16981, refs #16756 !strict

Note: See TracTickets for help on using tickets.