Opened 7 years ago

Closed 6 years ago

#16752 closed defect (fixed)

Switch, editable lists and IconContainer can miss touch.release events

Reported by: Eric Durocher Owned by: Patrick Ruzand
Priority: undecided Milestone: 1.9
Component: DojoX Mobile Version: 1.9.0a1
Keywords: Cc:
Blocked By: Blocking:

Description

Since dojo/touch now fires touch.release events only on the node where the finger was released (see [30557/dojo]), some Dojo Mobile code is broken because it assumed the native touch behavior, which was to fire the event on the same node as touch.press.

To reproduce:

  • dojox/mobile/tests/test_Switch.html: drag the knob of any switch, move the finger out of the switch, release -> the know stays blockedin the middle of the switch instead of going to the nearest end.
  • dojox/mobile/tests/test_RoundRectList-editable.html: click Edit, drag an item using the right icon, move out of the screen, remove finger: the dragged list item ghost stays visible at its current position.
  • dojox/mobile/tests/test_IconContainer-editable.html: click Start Edit, drag an icon, move out of the screen, remove finger: the dragged icon stays at its current position (near the border of the container).

Attachments (1)

touchend_on_doc.patch (2.5 KB) - added by Eric Durocher 7 years ago.
Fixes missing touch.release events on some dojox.mobile widgets by always listening to touch.release on the toplevel document - Eric Durocher (IBM, CCLA)

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by Eric Durocher

Attachment: touchend_on_doc.patch added

Fixes missing touch.release events on some dojox.mobile widgets by always listening to touch.release on the toplevel document - Eric Durocher (IBM, CCLA)

comment:1 Changed 6 years ago by Patrick Ruzand

Owner: changed from Eric Durocher to Patrick Ruzand
Status: newassigned

comment:2 Changed 6 years ago by Adrian Vasiliu

Milestone: tbd1.9

The fix has been committed already and is included in Dojo 1.9.0 and later. The commit is here: https://github.com/dojo/dojox/commit/b3be7993ff62b303bfd1fd906d2fe6a079a772fd Hence, I'm closing the ticket.

comment:3 Changed 6 years ago by Adrian Vasiliu

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.