Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#16738 closed defect (fixed)

many dojox/mvc doh tests are failing

Reported by: Ed Chatelain Owned by: Ed Chatelain
Priority: undecided Milestone: 1.9
Component: DojoX MVC Version: 1.8.3
Keywords: Cc:
Blocked By: Blocking:

Description

Many of the dojox/mvc doh tests are failing, it seems to be related to the changes for #16693

Change History (3)

comment:1 Changed 6 years ago by Ed Chatelain

asudoh has a potential workaround in this pull request: https://github.com/edchat/dojox_mvc/pull/73

But bill has indicated that he is planning to rollback his changes for #16693 for 1.9, so I am not going to merge the workaround for 1.9

comment:2 Changed 6 years ago by bill

Resolution: fixed
Status: newclosed

In [30659]:

Rollback [30599] and part of [30598]. They break code like dojox/mvc that dynamically adds setters to an instance, and also have a problem where defining a custom getter disables the code that automatically maps widget properties to DOMNode attributes (failing in dojox/mvc/Element.js for value property). As in 1.8, the dynamically added setters won't be automatically called on widget creation unless the property is specified as a parameter to the widget constructor. Refs #16693 and fixes #16738 !strict.

Also rolling back workaround code from [30639], refs #16737.

For 2.0 I'll probably have an API to add properties (with getters or setters) to an instance, and either remove or rearchitect how properties are automatically mapped to DOMNode attributes.

comment:3 Changed 6 years ago by bill

Milestone: tbd1.9
Note: See TracTickets for help on using tickets.