Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#16737 closed defect (fixed)

Cannot move items in editable IconContainer

Reported by: Eric Durocher Owned by: Eric Durocher
Priority: undecided Milestone: 1.9
Component: DojoX Mobile Version: 1.8.3
Keywords: Cc:
Blocked By: Blocking:

Description

This is a apparently a regression caused by [30598/dojo], see ticket:16693#comment:8.

Attachments (1)

16737.patch (712 bytes) - added by Eric Durocher 6 years ago.
Workaround for the regression, waiting for a better fix - Eric Durocher (IBM, CCLA)

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by Eric Durocher

Attachment: 16737.patch added

Workaround for the regression, waiting for a better fix - Eric Durocher (IBM, CCLA)

comment:1 Changed 6 years ago by cjolif

Resolution: fixed
Status: newclosed

In [30639]:

fixes #16737. Workaround for the regression, waiting for a better fix. Thanks Eric Durocher (IBM, CCLA)

comment:2 Changed 6 years ago by cjolif

Milestone: tbd1.9

comment:3 Changed 6 years ago by bill

In [30659]:

Rollback [30599] and part of [30598]. They break code like dojox/mvc that dynamically adds setters to an instance, and also have a problem where defining a custom getter disables the code that automatically maps widget properties to DOMNode attributes (failing in dojox/mvc/Element.js for value property). As in 1.8, the dynamically added setters won't be automatically called on widget creation unless the property is specified as a parameter to the widget constructor. Refs #16693 and fixes #16738 !strict.

Also rolling back workaround code from [30639], refs #16737.

For 2.0 I'll probably have an API to add properties (with getters or setters) to an instance, and either remove or rearchitect how properties are automatically mapped to DOMNode attributes.

Note: See TracTickets for help on using tickets.