Changes between Initial Version and Version 3 of Ticket #16726


Ignore:
Timestamp:
Feb 18, 2013, 10:33:04 PM (7 years ago)
Author:
bill
Comment:

I'll mark it as Dijit (rather than Dijit - form) since it's about the dijit/focus code.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #16726

    • Property Owner set to bill
    • Property Component changed from General to Dijit
  • Ticket #16726 – Description

    initial v3  
    1 After applying the fix for ticket:16752 and testing it on a IPad, I noticed that if the textbox has the focus and you click on it again to move the caret, you sometimes lose the focus and can't type any more even though the keyboard is still visible.  There is also strange behavior when you try to move the caret around.
     1After applying the fix for #16725 and testing it on a IPad, I noticed that if the textbox has the focus and you click on it again to move the caret, you sometimes lose the focus and can't type any more even though the keyboard is still visible.  There is also strange behavior when you try to move the caret around.
    22
    33I narrowed down the issue to the _setStack method of dijit/focus.  The code already determine what has changed in the stack and by the nature of the existing logic, pretty much does nothing if the stack doesn't change, with one exception.
    44
    5 It still calls this.set("acitveStack", newStack).
     5It still calls this.set("activeSatck", newStack).
    66
    77This call is causing the issue.  I really can't say why and ran out of time to debug it further, but it does mess up the IPad when your page is in an IFrame.
     
    99I figure this out by applying the following logic.
    1010{{{#!python
    11             if (nCommon == newStack.length && newStack.length == oldStack.length)
    12                 return;
     11if (nCommon == newStack.length && newStack.length == oldStack.length)
     12    return;
    1313}}}
    1414
    15 Please see dijit/tests/form/test_TextBoxIFrame.html (this was uploaded via a patch in ticket:16725).
     15Please see dijit/tests/form/test_TextBoxIFrame.html (this was uploaded via a patch in #16725).
    1616