Opened 8 years ago
Closed 5 years ago
#16717 closed enhancement (fixed)
allow a TabBar, through a new parameter, to resize its children so that they take all the available space in the bar
Reported by: | Sebastien Brunot | Owned by: | Patrick Ruzand |
---|---|---|---|
Priority: | undecided | Milestone: | 1.9 |
Component: | DojoX Mobile | Version: | 1.8.3 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Attached is a patch that add a parameter spreadChildren to dojox.mobile.TabBar. If this parameter is set to true, the bar buttons are resized so that they take all the available space in the bar. The patch also includes automated tests for this feature, plus manual tests.
Attachments (2)
Change History (11)
comment:1 Changed 8 years ago by
comment:2 Changed 8 years ago by
Looks mainly good, I am just a little concerned that the feature was already (half) there, except that children were resized only on screens < 500 pixels. So maybe that should be made more explicit... What about fill="auto/always/never", where auto is the "old" behavior (i.e. barStyle=tabBar and screen width < 500), and auto would be by default of course.
comment:3 Changed 8 years ago by
Sounds good: I've attached a new version of the patch that defines the "fill" parameter, instead of using spreadChildren.
Changed 8 years ago by
Attachment: | tabBarSpreadChildren.patch added |
---|
add the fill parameter to TabBar. If set to "auto" (default value), behave as in 1.8. If set to "always", resize its children so that they evenly fill the entire bar space. If set to "never", do not resize the children. (IBM CCLA).
Changed 8 years ago by
Attachment: | tabBarHolodark.patch added |
---|
Fix the issue with the holodark theme on TabBar with fill="always" (IBM CCLA)
comment:8 Changed 8 years ago by
Owner: | changed from Eric Durocher to Patrick Ruzand |
---|---|
Status: | new → assigned |
comment:9 Changed 5 years ago by
Milestone: | tbd → 1.9 |
---|---|
Resolution: | → fixed |
Status: | assigned → closed |
Patches were landed 3 years ago, closing as fixed.
IBM CCLA