Opened 6 years ago

Closed 3 years ago

#16717 closed enhancement (fixed)

allow a TabBar, through a new parameter, to resize its children so that they take all the available space in the bar

Reported by: Sebastien Brunot Owned by: Patrick Ruzand
Priority: undecided Milestone: 1.9
Component: DojoX Mobile Version: 1.8.3
Keywords: Cc:
Blocked By: Blocking:

Description

Attached is a patch that add a parameter spreadChildren to dojox.mobile.TabBar. If this parameter is set to true, the bar buttons are resized so that they take all the available space in the bar. The patch also includes automated tests for this feature, plus manual tests.

Attachments (2)

tabBarSpreadChildren.patch (39.3 KB) - added by Sebastien Brunot 6 years ago.
add the fill parameter to TabBar. If set to "auto" (default value), behave as in 1.8. If set to "always", resize its children so that they evenly fill the entire bar space. If set to "never", do not resize the children. (IBM CCLA).
tabBarHolodark.patch (5.4 KB) - added by Sebastien Brunot 6 years ago.
Fix the issue with the holodark theme on TabBar with fill="always" (IBM CCLA)

Download all attachments as: .zip

Change History (11)

comment:1 Changed 6 years ago by Sebastien Brunot

IBM CCLA

comment:2 Changed 6 years ago by Eric Durocher

Looks mainly good, I am just a little concerned that the feature was already (half) there, except that children were resized only on screens < 500 pixels. So maybe that should be made more explicit... What about fill="auto/always/never", where auto is the "old" behavior (i.e. barStyle=tabBar and screen width < 500), and auto would be by default of course.

comment:3 Changed 6 years ago by Sebastien Brunot

Sounds good: I've attached a new version of the patch that defines the "fill" parameter, instead of using spreadChildren.

Changed 6 years ago by Sebastien Brunot

Attachment: tabBarSpreadChildren.patch added

add the fill parameter to TabBar. If set to "auto" (default value), behave as in 1.8. If set to "always", resize its children so that they evenly fill the entire bar space. If set to "never", do not resize the children. (IBM CCLA).

comment:4 Changed 6 years ago by cjolif

In [30613]:

refs #16717. add a fill parameter to TabBar?. If set to "auto" (default value), behave as in 1.8. If set to "always", resize its children so that they evenly fill the entire bar space. If set to "never", do not resize the children. Thanks Sebastien Brunot (IBM CCLA).

comment:5 Changed 6 years ago by cjolif

ticket will be closed once added to release notes and documented.

comment:6 Changed 6 years ago by Sebastien Brunot

The patch does not work with the holodark theme.

Changed 6 years ago by Sebastien Brunot

Attachment: tabBarHolodark.patch added

Fix the issue with the holodark theme on TabBar with fill="always" (IBM CCLA)

comment:7 Changed 6 years ago by cjolif

In [30680]:

refs #16717. Fix the issue with the holodark theme on TabBar with fill="always". Thanks Sebastien Brunot and Damien Mandrioli (IBM CCLA).

comment:8 Changed 6 years ago by Patrick Ruzand

Owner: changed from Eric Durocher to Patrick Ruzand
Status: newassigned

comment:9 Changed 3 years ago by dylan

Milestone: tbd1.9
Resolution: fixed
Status: assignedclosed

Patches were landed 3 years ago, closing as fixed.

Note: See TracTickets for help on using tickets.