Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#16703 closed defect (fixed)

REGRESSION: Custom compatator maps on dojo.data.DataStores no longer work with sortByLabel true in Form widgets.

Reported by: Jared Jurkiewicz Owned by: bill
Priority: blocker Milestone: 1.8.4
Component: Dijit - Form Version: 1.8.0
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

It appears to be a bug in dijit/form/_FormSelectWidget.js

When Bill converted to use/allow the new dojo.store API, he broke a check that actually handles creating the sorter function. It doesn't test right/properly to identify the old store API

This:

if(this.sortByLabel && !fetchArgs.sort && items.length){
	if(items[0].getValue){
...

Should be:

if (this.sortByLabel && !fetchArgs.sort && items.length) {
       	if (store.getValue) {
...

Attachments (1)

16703.patch (573 bytes) - added by Jared Jurkiewicz 7 years ago.
Patch for this.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 7 years ago by Jared Jurkiewicz

Priority: undecidedblocker

Changed 7 years ago by Jared Jurkiewicz

Attachment: 16703.patch added

Patch for this.

comment:2 Changed 7 years ago by Jared Jurkiewicz

Description: modified (diff)

comment:3 Changed 7 years ago by bill

Description: modified (diff)
Milestone: tbd1.8.4
Owner: changed from Douglas Hays to bill
Status: newassigned
Version: 1.8.31.8.0

Refs #14866. OK, I'll check in that patch, thanks.

comment:4 Changed 7 years ago by bill

Resolution: fixed
Status: assignedclosed

In [30586]:

Fix regression using sortByLabel flag when Select connecting to legacy dojo.data store, fixes #16703, refs #14866 on 1.8 branch, !strict.

comment:5 Changed 7 years ago by bill

In [30587]:

Fix regression setting sort order when Select connecting to legacy dojo.data API, fixes #16703, refs #14866 on trunk, !strict.

Note: See TracTickets for help on using tickets.