Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#16701 closed defect (fixed)

SpinWheelSlot fails if passed empty string for labels property

Reported by: Adam Peller Owned by: Eric Durocher
Priority: undecided Milestone: 1.9
Component: DojoX Mobile Version: 1.8.3
Keywords: Cc: avasiliu
Blocked By: Blocking:

Description (last modified by Adam Peller)

This edge case causes a loop

in SpinWheelSlot.js, where len is 0:

108	                                var len = this.items.length;
109	                                var n = Math.ceil(this.minItems / len);

see also the problem report in Maqetta: https://github.com/maqetta/maqetta/issues/3409 where a workaround was implemented

Attachments (1)

patch16701.patch (4.1 KB) - added by Adrian Vasiliu 6 years ago.
Support the edge-case of empty slots - Adrian Vasiliu (IBM, CCLA)

Download all attachments as: .zip

Change History (7)

comment:1 Changed 6 years ago by Adam Peller

Description: modified (diff)
Status: newassigned

comment:2 Changed 6 years ago by cjolif

Cc: avasiliu added

Changed 6 years ago by Adrian Vasiliu

Attachment: patch16701.patch added

Support the edge-case of empty slots - Adrian Vasiliu (IBM, CCLA)

comment:3 Changed 6 years ago by Eric Durocher

@peller, this will be fixed in 1.9, do you need a backport in 1.8?

comment:4 Changed 6 years ago by cjolif

Resolution: fixed
Status: assignedclosed

In [30614]:

fixes #16652, #16701. Fix SpinWheelSlot value and key getters to return non-null before startup as well as support the edge-case of empty slots. Thanks Eric Durocher and Adrian Vasiliu (IBM, CCLA).

comment:5 Changed 6 years ago by cjolif

Milestone: tbd1.9

comment:6 Changed 6 years ago by Adam Peller

@edurocher, I'll take you up on the 1.8 backport for #16652 and #16701. thanks!

Note: See TracTickets for help on using tickets.