Opened 6 years ago
Last modified 3 years ago
#16700 assigned enhancement
[patch][cla] Fixed bars support for all types of views
| Reported by: | Sebastien Brunot | Owned by: | Sebastien Brunot |
|---|---|---|---|
| Priority: | undecided | Milestone: | 1.15 |
| Component: | DojoX Mobile | Version: | 1.8.3 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description (last modified by )
Currently, only ScrollableView support fixed bars positioned using a property "fixed" set to either "top" or "bottom". The included patch extends this support to all types of views (ScrollableView, View and SwapView), and provides a set of automated and manual tests to verify this support in different conditions (app / view bars, mix of those...).
To avoid regression in existing applications, this support is not enabled by default. To enable it, the dojo configuration property mblFixedBarsSupportForViews must be set to true. When the support is enabled and that at least one footer is defined (application and or view bottom fixed bar), the height of the views are automatically calculated and set in pixels each time the view is resized. To avoid this and manually set the view height using CSS, the view attribute resizeHeightEnabled can be set to the boolean value false.
This patch is provided with the IBM CCLA.
Attachments (1)
Change History (8)
comment:1 Changed 6 years ago by
| Description: | modified (diff) |
|---|
comment:2 Changed 6 years ago by
| Milestone: | tbd → 1.9 |
|---|
comment:3 Changed 6 years ago by
| Owner: | changed from Eric Durocher to Sebastien Brunot |
|---|---|
| Status: | new → assigned |
Changed 6 years ago by
| Attachment: | fixedBarSupport.patch added |
|---|
comment:4 Changed 6 years ago by
| Milestone: | 1.9 → 2.0 |
|---|
comment:5 Changed 3 years ago by
| Milestone: | 2.0 → 1.12 |
|---|---|
| Summary: | Fixed bars support for all types of views → [patch][cla] Fixed bars support for all types of views |
Patch is large... should this be landed, or closed?
comment:6 Changed 3 years ago by
per comment:4, the patch is not ready as-is, so I suggest we close it because we can't land it as-is.
comment:7 Changed 3 years ago by
| Milestone: | 1.13 → 1.15 |
|---|
Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.
For now we don't think this will be ready for 1.9, so let's punt it. If it happens this is ready in time we will put in back.