Opened 6 years ago

Last modified 2 years ago

#16700 assigned enhancement

[patch][cla] Fixed bars support for all types of views

Reported by: Sebastien Brunot Owned by: Sebastien Brunot
Priority: undecided Milestone: 1.15
Component: DojoX Mobile Version: 1.8.3
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by cjolif)

Currently, only ScrollableView support fixed bars positioned using a property "fixed" set to either "top" or "bottom". The included patch extends this support to all types of views (ScrollableView, View and SwapView), and provides a set of automated and manual tests to verify this support in different conditions (app / view bars, mix of those...).

To avoid regression in existing applications, this support is not enabled by default. To enable it, the dojo configuration property mblFixedBarsSupportForViews must be set to true. When the support is enabled and that at least one footer is defined (application and or view bottom fixed bar), the height of the views are automatically calculated and set in pixels each time the view is resized. To avoid this and manually set the view height using CSS, the view attribute resizeHeightEnabled can be set to the boolean value false.

This patch is provided with the IBM CCLA.

Attachments (1)

fixedBarSupport.patch (204.3 KB) - added by Sebastien Brunot 6 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 6 years ago by cjolif

Description: modified (diff)

comment:2 Changed 6 years ago by cjolif

Milestone: tbd1.9

comment:3 Changed 6 years ago by Eric Durocher

Owner: changed from Eric Durocher to Sebastien Brunot
Status: newassigned

Changed 6 years ago by Sebastien Brunot

Attachment: fixedBarSupport.patch added

comment:4 Changed 6 years ago by cjolif

Milestone: 1.92.0

For now we don't think this will be ready for 1.9, so let's punt it. If it happens this is ready in time we will put in back.

comment:5 Changed 3 years ago by dylan

Milestone: 2.01.12
Summary: Fixed bars support for all types of views[patch][cla] Fixed bars support for all types of views

Patch is large... should this be landed, or closed?

comment:6 Changed 3 years ago by cjolif

per comment:4, the patch is not ready as-is, so I suggest we close it because we can't land it as-is.

comment:7 Changed 2 years ago by dylan

Milestone: 1.131.15

Ticket planning... move current 1.13 tickets out to 1.15 to make it easier to move tickets into the 1.13 milestone.

Note: See TracTickets for help on using tickets.