Opened 7 years ago

Closed 7 years ago

#16696 closed task (fixed)

Refactoring dojox/charting to load bidi code conditionally

Reported by: semion18 Owned by: cjolif
Priority: undecided Milestone: 1.9
Component: Charting Version: 1.8.3
Keywords: Cc:
Blocked By: Blocking:

Description

Modules containing bidi code for dojox/charting, should be loaded and extend corresponding base classes when user sets "has: {'dojo-bidi': true }" in data-dojo-config. This is similar to what is already done for dojox/mobile.

Attachments (3)

charting5.patch​ (64.2 KB) - added by cjolif 7 years ago.
patches to implement dojo-bidi in charting, thanks Semion Chichelnitsky (IBM, CCLA)
charting7.patch​ (75.8 KB) - added by cjolif 7 years ago.
Update patch taking into account some feedback, thanks Semion Chichelnitsky (IBM, CCLA)
charting8.patch​ (134.3 KB) - added by cjolif 7 years ago.
updated patch with tests from Semion Chicelnitsky (IBM, CCLA)

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by cjolif

Component: Dojox → Charting
Milestone: tbd → 1.9
Owner: changed from Adam Peller to cjolif
Status: new → assigned

Changed 7 years ago by cjolif

Attachment: charting5.patch​ added

patches to implement dojo-bidi in charting, thanks Semion Chichelnitsky (IBM, CCLA)

Changed 7 years ago by cjolif

Attachment: charting7.patch​ added

Update patch taking into account some feedback, thanks Semion Chichelnitsky (IBM, CCLA)

Changed 7 years ago by cjolif

Attachment: charting8.patch​ added

updated patch with tests from Semion Chicelnitsky (IBM, CCLA)

comment:2 Changed 7 years ago by cjolif

In [30596]:

refs #16696. Refactoring dojox/charting to load bidi code conditionally. Thanks Semion Chichelnitsky (IBM, CCLA). !strict.

comment:3 Changed 7 years ago by ben hockey

In [30658]:

remove trailing comma introduced in r30596

refs #16696 fixes #16748 !strict

comment:4 Changed 7 years ago by cjolif

Resolution: → fixed
Status: assigned → closed
Note: See TracTickets for help on using tickets.