Changes between Initial Version and Version 1 of Ticket #16693


Ignore:
Timestamp:
Feb 11, 2013, 2:05:59 AM (8 years ago)
Author:
bill
Comment:

Some changes already checked in for this include [30567] and [30569].

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #16693

    • Property Status changed from new to assigned
    • Property Milestone changed from tbd to 2.0
  • Ticket #16693 – Description

    initial v1  
    33The preparatory work includes making sure all custom setters store their values by calling this._set(...) instead of directly calling this.foo = bar, since the latter causes an infinite recursion.   This is actually leftover work from #11251.
    44
    5 In addition, for getters _getXYZAttr() that reference this.XYZ, possibly add a level of indirection.  I think eventually they will access this.props.XYZ instead.
     5In addition, for getters _getXYZAttr() that reference this.XYZ, possibly add a level of indirection.  I think eventually they will access this.props.XYZ instead.   Alternately, there's probably some overuse of custom getters, which should be removed [and replaced by custom setters], for example !ValidationTextBox::_getPatternAttr().