Changes between Initial Version and Version 1 of Ticket #16680, comment 5


Ignore:
Timestamp:
Mar 1, 2013, 9:18:09 AM (8 years ago)
Author:
bill
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #16680, comment 5

    initial v1  
    1111}}}
    1212
    13 The intention of the editor.focus() call is to move focus from the !FilteringSelect back to the editor content after the user has selected a value.    However, since focus has already shifted to the second editor, this focus() call is bad.
     13The intention of the {{{this.editor.focus()}}} call is that after the user selects a font, focus is moved from the !FilteringSelect back to the editor content.  However, since focus has already shifted to the second editor, this focus() call is bad.
    1414
    15 I could workaround the problem by putting a if(this.editor._focused){ ... } around the this.editor.focus() call, but it seems like the root issue (greatly exacerbated by the setTimeout delay in onChange notifications) is that the !FilteringSelect is firing an unwanted onChange notification.
     15I could workaround the problem by putting a {{{if(this.editor._focused){ ... } }}} around the {{{this.editor.focus()}}} call, but it seems like the root issue (greatly exacerbated by the setTimeout delay in onChange notifications) is that the !FilteringSelect is firing an unwanted onChange notification.
    1616
    1717FYI, this code in !RichText.js seems related to the hang, probably because the iframe onfocus event also occurs on a delay: