#16668 closed defect (fixed)
DOH node runner broken
Reported by: | Kitson Kelly | Owned by: | bill |
---|---|---|---|
Priority: | undecided | Milestone: | 1.9 |
Component: | TestFramework | Version: | 1.8.3 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
The following command is broken in trunk, but works fine in 1.8:
node ../../dojo/dojo.js load=doh test=doh/tests/selfTest
In trunk it outputs:
------------------------------------------------------------ The Dojo Unit Test Harness, $Rev: 23869 $ Copyright (c) 2011, The Dojo Foundation, All Rights Reserved Running with node.js /Users/kitsonk/Documents/dtk/util/doh/_nodeRunner.js:27 for (var tests= [], args=doh.config["commandLineArgs"], i= 0, arg; i<args.len ^ TypeError: Cannot read property 'commandLineArgs' of undefined at /Users/kitsonk/Documents/dtk/util/doh/_nodeRunner.js:27:37 at runFactory (/Users/kitsonk/Documents/dtk/dojo/dojo.js:1094:43) at execModule (/Users/kitsonk/Documents/dtk/dojo/dojo.js:1223:5) at execModule (/Users/kitsonk/Documents/dtk/dojo/dojo.js:1214:12) at contextRequire (/Users/kitsonk/Documents/dtk/dojo/dojo.js:789:7) at guardCheckComplete (/Users/kitsonk/Documents/dtk/dojo/dojo.js:1238:5) at contextRequire (/Users/kitsonk/Documents/dtk/dojo/dojo.js:788:6) at result (/Users/kitsonk/Documents/dtk/dojo/dojo.js:808:13) at Object.has.load (/Users/kitsonk/Documents/dtk/dojo/has.js:166:4) at injectPlugin (/Users/kitsonk/Documents/dtk/dojo/dojo.js:1312:13)
Change History (6)
comment:1 Changed 9 years ago by
Milestone: | tbd → 1.9 |
---|---|
Owner: | set to wildbill |
Status: | new → assigned |
comment:2 Changed 9 years ago by
Owner: | changed from wildbill to bill |
---|
Yes, likely I broke that, or did something that requires updating the test.
comment:3 Changed 9 years ago by
Just to clarify, I can't get any test to run... the obvious example is the self test, but I discovered it when trying to run the dojo/node
tests to try to checkout a patch before checking in a fix for an issue.
comment:5 Changed 9 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Appears to be fixed now...
comment:6 Changed 9 years ago by
Right, fixed in [30538], forgot to reference this ticket in the check in comment.
Note: See
TracTickets for help on using
tickets.
I can't figure out what part is actually broken, but Bill appears to be the last person to touch this area of code, so assigning to him.