#16652 closed defect (fixed)
SpinWheelSlot takes measurements prior to startup
| Reported by: | Adam Peller | Owned by: | Eric Durocher |
|---|---|---|---|
| Priority: | undecided | Milestone: | 1.9 |
| Component: | DojoX Mobile | Version: | 1.8.3 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
Old code in SpinWheelSlot. getCenterItem() violates the Dijit API contract and is causing trouble for us on Maqetta.
Attachments (1)
Change History (8)
comment:2 Changed 7 years ago by
I understand, but it is usually some very complex interaction which is difficult to isolate (part of what makes the bugs so frustrating) I don't yet have a standalone example, but because of the nature of this exercise, it's less important from a testing point of view, it's more about compliance with the API.
comment:3 Changed 7 years ago by
I attached a simple patch that addresses specifically the case when get("value") or get("key") are called before startup(). Can you please try this in Maqetta and see if it fixes your problems?
Changed 7 years ago by
| Attachment: | 16652.patch added |
|---|
Fix SpinWheelSlot value and key getters to return non-null before startup - Eric Durocher (IBM, CCLA)
comment:5 Changed 7 years ago by
OK this will be fixed in 1.9, please tell if you need a backport in 1.8.
comment:7 Changed 7 years ago by
| Milestone: | tbd → 1.9 |
|---|
I basically agree with the fact that these "value" and "key" getters that rely on layout are a pain and need to be fixed. On the other hand, I am not sure from the Maqetta issue what exact scenario is causing trouble. Is it "just" getting values before startup()? Ideally a standalone HTML sample would be really helpful.