Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#16652 closed defect (fixed)

SpinWheelSlot takes measurements prior to startup

Reported by: Adam Peller Owned by: Eric Durocher
Priority: undecided Milestone: 1.9
Component: DojoX Mobile Version: 1.8.3
Keywords: Cc:
Blocked By: Blocking:

Description

Old code in SpinWheelSlot. getCenterItem() violates the Dijit API contract and is causing trouble for us on Maqetta.

Attachments (1)

16652.patch (2.0 KB) - added by Eric Durocher 6 years ago.
Fix SpinWheelSlot value and key getters to return non-null before startup - Eric Durocher (IBM, CCLA)

Download all attachments as: .zip

Change History (8)

comment:1 Changed 6 years ago by Eric Durocher

I basically agree with the fact that these "value" and "key" getters that rely on layout are a pain and need to be fixed. On the other hand, I am not sure from the Maqetta issue what exact scenario is causing trouble. Is it "just" getting values before startup()? Ideally a standalone HTML sample would be really helpful.

Last edited 6 years ago by Eric Durocher (previous) (diff)

comment:2 Changed 6 years ago by Adam Peller

I understand, but it is usually some very complex interaction which is difficult to isolate (part of what makes the bugs so frustrating) I don't yet have a standalone example, but because of the nature of this exercise, it's less important from a testing point of view, it's more about compliance with the API.

comment:3 Changed 6 years ago by Eric Durocher

I attached a simple patch that addresses specifically the case when get("value") or get("key") are called before startup(). Can you please try this in Maqetta and see if it fixes your problems?

Changed 6 years ago by Eric Durocher

Attachment: 16652.patch added

Fix SpinWheelSlot value and key getters to return non-null before startup - Eric Durocher (IBM, CCLA)

comment:4 Changed 6 years ago by Adam Peller

Brilliant. Thanks, Eric!

comment:5 Changed 6 years ago by Eric Durocher

OK this will be fixed in 1.9, please tell if you need a backport in 1.8.

comment:6 Changed 6 years ago by cjolif

Resolution: fixed
Status: newclosed

In [30614]:

fixes #16652, #16701. Fix SpinWheelSlot value and key getters to return non-null before startup as well as support the edge-case of empty slots. Thanks Eric Durocher and Adrian Vasiliu (IBM, CCLA).

comment:7 Changed 6 years ago by cjolif

Milestone: tbd1.9
Note: See TracTickets for help on using tickets.