[patch][cla] dojox.mobile.ProgressIndicator is not vertically centered

[dg]

In dojox/mobile/themes/common/ProgressIndicator.less

.mblProgressIndicatorCenter {

position: absolute; top: 180px; left: 50%;

}

A naive fix would be to have top:50% and also fix:

.mblProgressIndicatorCenter .mblProgContainer {

left: -50%; top: -50%;

}

Unfortunately, I cannot test on lots of devices if it brakes something..

[Sebastien Pereira]

I don't see any side effect related to a particular device/os (tested on android/ios/BB and WP). However I found a potential side effect due to the usage of the ProgressIndicator? with the current CSS. It is illustrated by this test/example: ​https://github.com/dojo/dojox/blob/master/mobile/tests/test_ProgressIndicator.html

The ProgressIndicator? is attached to the view (container, line 31), which height is 0 (until it is loaded). So the top:180px makes the Progressindicator "far" from the top...

If we replace top:180px by a percentage the PI will stick to the top, unless the application (in that specific case) attaches the PI to the body, which I think, is a better way to do.

container.appendChild(prog.domNode);
//would have to be:
win.body().appendChild(prog.domNode);
// with "win" a require of "dojo/_base/window"

Also, the propose solution can be improved/simplified like this:

.mblProgressIndicatorCenter {
	position: absolute;
	left: 0;
	right: 0;
	bottom: 0;
	top:0;
	margin: auto;
}

.mblProgressIndicatorCenter .mblProgContainer {
}

I'll propose a PR with these changes.

[Sebastien Pereira]

Ref: ​https://github.com/dojo/dojox/pull/79

[Patrick Ruzand]

Since this patch may have some side effects on existing app, I'm closing the ticket as wont fix. Users may still apply the patch if the limitation (see comment 4 above) fits their use case.