Opened 9 years ago
Closed 9 years ago
#16642 closed defect (fixed)
[email protected] -- ReferenceError: registry is not defined
Reported by: | Paul Christopher | Owned by: | bill |
---|---|---|---|
Priority: | undecided | Milestone: | 1.9 |
Component: | Dijit | Version: | 1.8.3 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Description
Go to http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/themes/themeTester.html. On the left hand side, open the accordion "Popup and Alerts". Click on "Show loading modal dialog". This gives you a ReferenceError: Registry is not defined.
Discussion
I think the reason is the onclick-handler which is put directly on the node like this:
<a href="#" onclick="registry.byId('dialog1').show()">slow loading modal dialog</a>
registry is undefined in the global scope. Maybe data-dojo-id should be used instead? Or is it better to move the code inside the require statement so as to avoid global variables?
Please note: There are more onclick handlers that reference registry directly and thus produce an error.
Change History (2)
comment:1 Changed 9 years ago by
Component: | General → Dijit |
---|---|
Milestone: | tbd → 1.9 |
Owner: | set to bill |
Status: | new → assigned |
comment:2 Changed 9 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
In [30502]: