[email protected] -- ReferenceError: registry is not defined

[Paul Christopher]

Description

Go to ​http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/themes/themeTester.html. On the left hand side, open the accordion "Popup and Alerts". Click on "Show loading modal dialog". This gives you a ReferenceError: Registry is not defined.

Discussion

I think the reason is the onclick-handler which is put directly on the node like this:

<a href="#" onclick="registry.byId('dialog1').show()">slow loading modal dialog</a>

registry is undefined in the global scope. Maybe data-dojo-id should be used instead? Or is it better to move the code inside the require statement so as to avoid global variables?

Please note: There are more onclick handlers that reference registry directly and thus produce an error.

[bill]

In [30502]:

fix themeTester breakage from [30408], fixes #16642, refs #16585