Opened 6 years ago

Closed 6 years ago

#16642 closed defect (fixed)

ThemeTester@NightlyBuilds -- ReferenceError: registry is not defined

Reported by: Paul Christopher Owned by: bill
Priority: undecided Milestone: 1.9
Component: Dijit Version: 1.8.3
Keywords: Cc:
Blocked By: Blocking:

Description

Description

Go to http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/themes/themeTester.html. On the left hand side, open the accordion "Popup and Alerts". Click on "Show loading modal dialog". This gives you a ReferenceError: Registry is not defined.

Discussion

I think the reason is the onclick-handler which is put directly on the node like this:

<a href="#" onclick="registry.byId('dialog1').show()">slow loading modal dialog</a>

registry is undefined in the global scope. Maybe data-dojo-id should be used instead? Or is it better to move the code inside the require statement so as to avoid global variables?

Please note: There are more onclick handlers that reference registry directly and thus produce an error.

Change History (2)

comment:1 Changed 6 years ago by bill

Component: GeneralDijit
Milestone: tbd1.9
Owner: set to bill
Status: newassigned

comment:2 Changed 6 years ago by bill

Resolution: fixed
Status: assignedclosed

In [30502]:

fix themeTester breakage from [30408], fixes #16642, refs #16585

Note: See TracTickets for help on using tickets.