#16589 closed enhancement (fixed)
[patch] [cla] Select: allow type ahead on closed list
Reported by: | Bob Tarling | Owned by: | Douglas Hays |
---|---|---|---|
Priority: | undecided | Milestone: | 1.9 |
Component: | Dijit - Form | Version: | 1.8.3 |
Keywords: | Cc: | ||
Blocked By: | #16323 | Blocking: |
Description
The attached patch allows type ahead on a Select control when that control does not have its dropdown displayed.
Patch is from 1.9 trunk (not shown in trac version field)
Attachments (3)
Change History (14)
Changed 9 years ago by
Attachment: | Select.js.patch added |
---|
comment:1 Changed 9 years ago by
Summary: | [patch] Select: allow type ahead on closed list → [patch] [cla] Select: allow type ahead on closed list |
---|
Confirmed Robert Tarling filed a CLA.
comment:2 Changed 9 years ago by
Milestone: | tbd → 1.9 |
---|
Changed 9 years ago by
Attachment: | 16589.patch added |
---|
Implement search by letter with the dropdown closed using existing logic, including support for HOME and END keys
comment:3 Changed 9 years ago by
bobtarling, can you test with the 16589.patch file? It still needs a code review and automated tests.
comment:4 Changed 9 years ago by
The behaviour looks good to me through my own local testing. Clearly the implementation is better to reuse the existing logic.
comment:5 Changed 9 years ago by
Should it be extending _KeyNavMixin instead of _KeyNavContainer, since Select is not a dijit/Container widget? Maybe I just don't understand how it's working, since I don't see how the KeyNav code is getting access to the list of items in the drop down, i.e. I don't see how _getNextFocusableChild() is working.
comment:6 Changed 9 years ago by
Select needs _getNextFocusableChild and the HOME/END key processing in _KeyNavContainer (this is a lot of the entire mixin so I used it instead of copying code).
comment:7 Changed 9 years ago by
Blocked By: | 16323 added |
---|
Changed 9 years ago by
Attachment: | 16589_KeyNavMixin.patch added |
---|
patch that refactors _KeyNavContainer and _KeyNavMixin so Select only inherits from _KeyNavMixin
Patch to be applied to Select.js