[patch] [cla] Select: allow type ahead on closed list

[Bob Tarling]

The attached patch allows type ahead on a Select control when that control does not have its dropdown displayed.

Patch is from 1.9 trunk (not shown in trac version field)

[Bob Tarling]

Patch to be applied to Select.js

[bill]

Confirmed Robert Tarling filed a CLA.

[Douglas Hays]

Implement search by letter with the dropdown closed using existing logic, including support for HOME and END keys

[Douglas Hays]

bobtarling, can you test with the 16589.patch file? It still needs a code review and automated tests.

[Bob Tarling]

The behaviour looks good to me through my own local testing. Clearly the implementation is better to reuse the existing logic.

[bill]

Should it be extending _KeyNavMixin instead of _KeyNavContainer, since Select is not a dijit/Container widget? Maybe I just don't understand how it's working, since I don't see how the KeyNav code is getting access to the list of items in the drop down, i.e. I don't see how _getNextFocusableChild() is working.

[Douglas Hays]

Select needs _getNextFocusableChild and the HOME/END key processing in _KeyNavContainer (this is a lot of the entire mixin so I used it instead of copying code).

[Douglas Hays]

patch that refactors _KeyNavContainer and _KeyNavMixin so Select only inherits from _KeyNavMixin

[Douglas Hays]

added new patch to reduce Select inheritance

[Douglas Hays]

In [30620]:

Fixes #16589. Refactor _KeyNavMixin and _KeyNavContainer so Select can inherit keysearch and HOME/END functionality through inheritance from _KeyNavMixin. Add automated Select tests. !strict

[bill]

In [31167]:

fix dangling "registry" parameter in AMD declaration, which was neither used nor defined, refs #16589

[bill]

In [31291]:

Roll back the [31124] change to _HasDropDown so it can come before or after _KeyNavMixin in the inheritance chain, thus allowing Select to have a saner list of superclasses. Fixes #17040, refs #16589 !strict.