Opened 6 years ago

Closed 6 years ago

#16588 closed enhancement (fixed)

Improve the theme compiling mechanism to reduce the number of .less files

Reported by: Damien Mandrioli Owned by: Eric Durocher
Priority: undecided Milestone: 1.9
Component: DojoX Mobile Version: 1.8.3
Keywords: Cc: cjolif
Blocked By: Blocking:

Description

Dojo Mobile theme folders contains hundreds of .less files which follow the same pattern. For example, Checkbox.less is duplicated in each theme folder and contains always these two lines:

@import "variables.less"; @import "../common/CheckBox.less";

The idea is to remove all .less files that follow this pattern and adapt the compilation script to keep as-is the CSS generation.

Here is the procedure: For each .less file in 'common'

If a .less file with the same name exists in the theme being compiled then it is used Otherwise the 'common' version is used and prefixed by: @import "variables.less";

A cleanup script will also be provided to remove generated CSS files.

Attachments (1)

theming_simplification.patch (93.4 KB) - added by Damien Mandrioli 6 years ago.
Remove 200+ .less files, create a utils folder containing new compilation scripts (Damien Mandrioli, IBM CCLA)

Download all attachments as: .zip

Change History (11)

comment:1 Changed 6 years ago by cjolif

Cc: cjolif added
Milestone: tbd1.9

comment:2 Changed 6 years ago by cjolif

The .js files in themes/utils should probably be excluded from the dojox package build profile are they are not supposed to be built? Have you verify the build after applying your patch?

comment:3 Changed 6 years ago by Damien Mandrioli

You're right. I have updated the patch.

Changed 6 years ago by Damien Mandrioli

Remove 200+ .less files, create a utils folder containing new compilation scripts (Damien Mandrioli, IBM CCLA)

comment:4 Changed 6 years ago by cjolif

In [30434]:

refs #16588. Remove duplicated LESS files and enhance mobile LESS compilation to take that into account. Thanks Damien Mandrioli (IBM, CCLA).

comment:5 Changed 6 years ago by cjolif

In [30435]:

refs #16588. Remove un-needed file

comment:6 Changed 6 years ago by cjolif

will be closed when in release notes and documented, thanks Damien.

comment:7 Changed 6 years ago by cjolif

In [30436]:

refs #16588. Add forgotten files.

comment:8 Changed 6 years ago by cjolif

In [30438]:

refs #16588. Actually remove the files not just emptied them.

comment:10 Changed 6 years ago by cjolif

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.