Opened 7 years ago

Closed 7 years ago

#16580 closed defect (fixed)

Bad urls in TriStateCheckbox.css

Reported by: Adam Peller Owned by: Adam Peller
Priority: undecided Milestone: 1.8.4
Component: DojoX Form Version: 1.8.3
Keywords: Cc: cjolif
Blocked By: Blocking:

Description (last modified by Adam Peller)

../image urls should not have the ".." Causes fatal errors when using the build tool

Change History (9)

comment:1 Changed 7 years ago by Adam Peller

Cc: cjolif added
Owner: changed from dante to Adam Peller
Status: newassigned

comment:2 Changed 7 years ago by Adam Peller

Description: modified (diff)
Milestone: tbd1.8.4

looking further, the images do not exist and the rules do not appear to be used, so they should simply be removed. wondering if this needs to be backported

Last edited 7 years ago by Adam Peller (previous) (diff)

comment:3 Changed 7 years ago by Adam Peller

Description: modified (diff)

comment:4 Changed 7 years ago by cjolif

I wanted to double check but the test is failing for me on trunk.

Error on domReady callback: TypeError: Cannot read property 'tagName' of undefined 

Don't you have the problem as well?

comment:5 Changed 7 years ago by Adam Peller

I was only looking at 1.8. You're correct, there is some other regression on trunk.

comment:6 Changed 7 years ago by cjolif

comment:7 Changed 7 years ago by cjolif

The trunk regression is now fixed. I confirm these selectors are never fired, so yes we can probably remove those rules entirely.

comment:8 Changed 7 years ago by Adam Peller

In [30444]:

Remove unused selectors with invalid paths refs #16580

comment:9 Changed 7 years ago by Adam Peller

Resolution: fixed
Status: assignedclosed

In [30445]:

Remove unused selectors with invalid paths fixes #16580

Note: See TracTickets for help on using tickets.