Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#16577 closed task (fixed)

convert DOH to baseless

Reported by: bill Owned by: bill
Priority: undecided Milestone: 1.9
Component: TestFramework Version: 1.8.3
Keywords: Cc:
Blocked By: Blocking:

Description

Stop accessing dojo/main from DOH modules, and stop using the dojo and dojox globals. #14929 did the AMD conversion but didn't convert the files to baseless.

Change History (4)

comment:1 Changed 7 years ago by bill

Milestone: tbd → 1.9
Owner: set to bill
Status: new → assigned

comment:2 Changed 7 years ago by bill

Resolution: → fixed
Status: assigned → closed

In [30354]:

Stop accessing dojo/main from DOH modules, and stop using the dojo and dojox globals. This includes stopping mixing in "dojo" into "doh". Hopefully no one was depending on that besides the DOH code itself. Fixes #16577 !strict.

comment:3 Changed 7 years ago by bill

In [30355]:

More fixes to stop accessing dojo/main from DOH modules.

Moved fixHeight() from _ParseURLargs.js to _browserRunner.js so I can use require() to get the dojo modules being used by that function. It turns out that fixHeight() is using a fair amount of dojo code (on IE9) in order to fix sizing of the runner.

Refs #16577 !strict.

comment:4 Changed 6 years ago by bill

In [30538]:

fix dependency on dojo/_base/config to get the command line arguments parsed by dojo.js, refs #16577 !strict

Note: See TracTickets for help on using tickets.