Changes between Initial Version and Version 1 of Ticket #16574, comment 3


Ignore:
Timestamp:
Jan 15, 2013, 1:55:08 PM (8 years ago)
Author:
mikeb
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #16574, comment 3

    initial v1  
    11Replying to [comment:1 bill]:
    22> Is there some reason (in Tree.js) you are calling {{{this.domNode.getAttribute("aria-label")}}} instead of just doing {{{this["aria-label"]}}}?
    3 No there isn't, using this["aria-label"] is better. I updated the patches.
     3No there isn't, using {{{this["aria-label"]}}} is better. I updated the patches.
    44
    55> It also seems slightly suboptimal since the user can't change the aria-label or aria-labelled-by after initialization, but probably that won't be a problem in practice.