[PATCH][CCLA] Tree: set aria-label on rootless Trees

[mikeb]

[29284] and [28332] correctly set up the roles and attributes for accessibility for dijit.Trees. However, I accidentally forgot about moving the aria-label (or aria-labelledby) attribute to the correct node in the case of a rootless tree. I attached a patch that moves the aria-label (or aria-labelledby) attribute to the correct node (the same node that gets the role=tree attribute.) Also attached some automated test cases.

[bill]

Is there some reason (in Tree.js) you are calling this.domNode.getAttribute("aria-label") instead of just doing this["aria-label"]?

It also seems slightly suboptimal since the user can't change the aria-label or aria-labelled-by after initialization, but probably that won't be a problem in practice.

[mikeb]

Adds aria-label attribute to rootless trees on 1.8, please commit for Michael Billau CCLA on file

[mikeb]

Attachment (aria-label-rootles-trees-1.8) added by ticket reporter.

[mikeb]

Adds aria-label attribute to rootless trees, please commit for Michael Billau CCLA on file

[mikeb]

Replying to bill:

Is there some reason (in Tree.js) you are calling this.domNode.getAttribute("aria-label") instead of just doing this["aria-label"]?

No there isn't, using this["aria-label"] is better. I updated the patches.

It also seems slightly suboptimal since the user can't change the aria-label or aria-labelled-by after initialization, but probably that won't be a problem in practice.

I also don't see this happening in practice, but I suppose if you would prefer I can add a setAriaLabelattr method instead.

[bill]

Probably it's not worth the effort. I'll check in your patches as is, thanks.

[bill]

In [30383]:

Fix aria labels for showRoot=false trees, patch from Mike Billau (IBM, CCLA), fixes #16574 on trunk !strict

[bill]

In [30384]:

Fix aria labels for showRoot=false trees, patch from Mike Billau (IBM, CCLA), fixes #16574 on 1.8 branch !strict