#16574 closed defect (fixed)
[PATCH][CCLA] Tree: set aria-label on rootless Trees
Reported by: | mikeb | Owned by: | mikeb |
---|---|---|---|
Priority: | undecided | Milestone: | 1.8.4 |
Component: | Dijit | Version: | 1.8.3 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
[29284] and [28332] correctly set up the roles and attributes for accessibility for dijit.Trees. However, I accidentally forgot about moving the aria-label (or aria-labelledby) attribute to the correct node in the case of a rootless tree. I attached a patch that moves the aria-label (or aria-labelledby) attribute to the correct node (the same node that gets the role=tree attribute.) Also attached some automated test cases.
Attachments (2)
Change History (8)
comment:1 follow-up: 3 Changed 8 years ago by
Owner: | changed from bill to mikeb |
---|---|
Status: | new → pending |
Changed 8 years ago by
Attachment: | aria-label-rootles-trees-1.8 added |
---|
Adds aria-label attribute to rootless trees on 1.8, please commit for Michael Billau CCLA on file
comment:2 Changed 8 years ago by
Status: | pending → new |
---|
Attachment (aria-label-rootles-trees-1.8) added by ticket reporter.
Changed 8 years ago by
Attachment: | add-aria-label-to-rootless-trees.patch added |
---|
Adds aria-label attribute to rootless trees, please commit for Michael Billau CCLA on file
comment:3 Changed 8 years ago by
Replying to bill:
Is there some reason (in Tree.js) you are calling
this.domNode.getAttribute("aria-label")
instead of just doingthis["aria-label"]
?
No there isn't, using this["aria-label"]
is better. I updated the patches.
It also seems slightly suboptimal since the user can't change the aria-label or aria-labelled-by after initialization, but probably that won't be a problem in practice.
I also don't see this happening in practice, but I suppose if you would prefer I can add a setAriaLabelattr method instead.
comment:4 Changed 8 years ago by
Milestone: | tbd → 1.8.4 |
---|---|
Summary: | [PATCH][CCLA] dijit.Tree: set aria-label on rootless Trees → [PATCH][CCLA] Tree: set aria-label on rootless Trees |
Probably it's not worth the effort. I'll check in your patches as is, thanks.
Is there some reason (in Tree.js) you are calling
this.domNode.getAttribute("aria-label")
instead of just doingthis["aria-label"]
?It also seems slightly suboptimal since the user can't change the aria-label or aria-labelled-by after initialization, but probably that won't be a problem in practice.