dojox/socket broken in Dojo 1.8.X

[Tony Merc Mobily]

Hi,

​http://jsfiddle.net/mercmobily/FdPM5/

Basically, even this:

socket = new Socket("/comet");

Fails. The only way for me to make it work is by patching on.js, line 306:

if(target.dispatchEvent && document.createEvent){

Into:

if(target.dispatchEvent && document && document.createEvent && target.ownerDocument ){

I don't quite understand the changes in the way events are handled between Dojo 1.7 and 1.8 (before, it was all nice and separate, now it looks like events travel from DOM to Widgets and vice versa...?)

Anyhow, is dojox/socket still supported? What shall I use instead for comet-like communication?

Merc.

[kaluzkidemjan]

still broken on 1.9.2, please fix it

[kaluzkidemjan]

seems to be already fixed in master: ​https://github.com/dojo/dojo/commit/3beccffc21fbcd3e21681fc74a29b0c56a31572f#diff-4c49831e3963859b06f08565a3dd03ab

are you going to merge it at least in 1.9 branch?

[Kris Zyp]

Replying to kaluzkidemjan:

seems to be already fixed in master: ​https://github.com/dojo/dojo/commit/3beccffc21fbcd3e21681fc74a29b0c56a31572f#diff-4c49831e3963859b06f08565a3dd03ab

are you going to merge it at least in 1.9 branch?

OK, I backported this to 1.8 and 1.9. Do you want to verify that it fixes your issue?

[bill]

FYI, I checked the 1.8 and 1.9 branches; I don't see any backport.

[Kris Zyp]

I believe this was applied to 1.8 and 1.8 in ​https://github.com/dojo/dojo/commit/47c2126a5c9b1163e251fc02dd3e38defa8245eb and ​https://github.com/dojo/dojo/commit/ec9b4282c097d7b2221e6c87f9f0b276299ffa24, and even though the commit doesn't seem to show the diff correctly, it seems to be in there in 1.8: ​https://github.com/dojo/dojo/blob/1.8/on.js#L307

[bill]

OK cool, so it's in 1.8.6 and 1.9.3.