Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#16564 closed defect (fixed)

[PATCH][CCLA] ProgressBar: correct ARIA roles and add automated tests

Reported by: mikeb Owned by: bill
Priority: undecided Milestone: 1.8.4
Component: Dijit Version: 1.8.3
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

#16000 added ARIA roles and attributes to the ProgressBar, however, there was a mistake and "aria-describedby" was used instead of "aria-labelledby" for the ProgressBar. I have attached a patch that changes this back to aria-labelledby. I have also added and tested some automated test cases to check for the roles and attributes.

(Also I am trying to set these tickets to milestone 1.9 but it is not available in the drop down?)

Attachments (3)

ProgressBar-a11y-roles-and-tests.patch (1.7 KB) - added by mikeb 6 years ago.
ProgressBar? - change aria-describedby to aria-labelledby, add automated test cases, please proxy commit for michael billau
ProgressBar-a11y-roles-tests-1.8 (1.7 KB) - added by mikeb 6 years ago.
change aria-describedby to aria-labelledby and add automated tests for 1.8 stream
2000.xp.vista.7.pbs.png (27.7 KB) - added by bill 5 years ago.
screenshot of progress bars with labels

Download all attachments as: .zip

Change History (10)

Changed 6 years ago by mikeb

ProgressBar? - change aria-describedby to aria-labelledby, add automated test cases, please proxy commit for michael billau

comment:1 Changed 6 years ago by mikeb

Could we please put this into 1.8? I attached a patch for that stream as well.

Changed 6 years ago by mikeb

change aria-describedby to aria-labelledby and add automated tests for 1.8 stream

comment:2 Changed 6 years ago by bill

OK, but you tabbing in the patch file is wrong again.

comment:3 Changed 6 years ago by bill

Description: modified (diff)
Milestone: tbd1.8.4
Summary: [PATCH][CCLA] dijit.ProgressBar - correct ARIA roles and add automated tests[PATCH][CCLA] ProgressBar: correct ARIA roles and add automated tests

comment:4 Changed 6 years ago by bill

PS: As for the 1.9 milestone, it is in the dropdown, at least for me. Probably you are getting confused because the dropdown is split into section for "Open" milestones and "Closed" milestones.

comment:5 Changed 6 years ago by bill

Resolution: fixed
Status: newclosed

In [30340]:

Fix ProgressBar aria attribute, fixes #16564 on 1.8 branch !strict, thanks Mike (IBM, CCLA).

comment:6 Changed 6 years ago by bill

In [30341]:

Fix ProgressBar aria attribute, and add aria tests, fixes #16564 on trunk !strict, thanks Mike (IBM, CCLA).

Changed 5 years ago by bill

Attachment: 2000.xp.vista.7.pbs.png added

screenshot of progress bars with labels

comment:7 Changed 5 years ago by bill

I believe the aria-labelledby was a mistake. In HTML/ARIA terminology a node's label is generally outside of the node, often to the left or above, and is specified by the application. For example, these progress bars have labels like "Block style" and "Continuous style":

screenshot of progress bars with labels

And the user should be able to specify that by:

<div id="bs">Block style</div>
<div data-dojo-type=dijit/ProgressBar aria-labelledby=bs>

Note that the ProgressBar?.html test file itself has examples of labels, although not properly annotated, but things like "Small, without text and background image:".

Last edited 5 years ago by bill (previous) (diff)
Note: See TracTickets for help on using tickets.