[PATCH][CCLA] ProgressBar: correct ARIA roles and add automated tests

[mikeb]

#16000 added ARIA roles and attributes to the ProgressBar, however, there was a mistake and "aria-describedby" was used instead of "aria-labelledby" for the ProgressBar. I have attached a patch that changes this back to aria-labelledby. I have also added and tested some automated test cases to check for the roles and attributes.

(Also I am trying to set these tickets to milestone 1.9 but it is not available in the drop down?)

[mikeb]

ProgressBar? - change aria-describedby to aria-labelledby, add automated test cases, please proxy commit for michael billau

[mikeb]

Could we please put this into 1.8? I attached a patch for that stream as well.

[mikeb]

change aria-describedby to aria-labelledby and add automated tests for 1.8 stream

[bill]

OK, but you tabbing in the patch file is wrong again.

[bill]

PS: As for the 1.9 milestone, it is in the dropdown, at least for me. Probably you are getting confused because the dropdown is split into section for "Open" milestones and "Closed" milestones.

[bill]

In [30340]:

Fix ProgressBar aria attribute, fixes #16564 on 1.8 branch !strict, thanks Mike (IBM, CCLA).

[bill]

In [30341]:

Fix ProgressBar aria attribute, and add aria tests, fixes #16564 on trunk !strict, thanks Mike (IBM, CCLA).

[bill]

screenshot of progress bars with labels

[bill]

I believe the aria-labelledby was a mistake. In HTML/ARIA terminology a node's label is generally outside of the node, often to the left or above, and is specified by the application. For example, these progress bars have labels like "Block style" and "Continuous style":

And the user should be able to specify that by:

<div id="bs">Block style</div>
<div data-dojo-type=dijit/ProgressBar aria-labelledby=bs>

Note that the ProgressBar?.html test file itself has examples of labels, although not properly annotated, but things like "Small, without text and background image:".