Opened 8 years ago
Closed 8 years ago
#16557 closed defect (fixed)
Build broken - ready.js throws undefined error
Reported by: | James Thomas | Owned by: | bill |
---|---|---|---|
Priority: | undecided | Milestone: | 1.9 |
Component: | Core | Version: | 1.8.3 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Running a basic build against trunk falls with the following error:
/Users/james/Code/DTK/current/dojo/ready.js:59
domReady._onQEmpty = onEvent;
TypeError?: Cannot set property '_onQEmpty' of undefined
at /Users/james/Code/DTK/current/dojo/ready.js:59:21 at runFactory (/Users/james/Code/DTK/current/dojo/dojo.js:1094:43) at execModule (/Users/james/Code/DTK/current/dojo/dojo.js:1223:5) at execModule (/Users/james/Code/DTK/current/dojo/dojo.js:1214:12) at execModule (/Users/james/Code/DTK/current/dojo/dojo.js:1214:12) at contextRequire (/Users/james/Code/DTK/current/dojo/dojo.js:789:7) at guardCheckComplete (/Users/james/Code/DTK/current/dojo/dojo.js:1238:5) at contextRequire (/Users/james/Code/DTK/current/dojo/dojo.js:788:6) at req (/Users/james/Code/DTK/current/dojo/dojo.js:124:11) at hasCache.host-browser (/Users/james/Code/DTK/current/dojo/dojo.js:1901:17)
Look at the recent comments, changes to ready.js seem responsible. The domReady dependency is ignored on non-browser platforms but in the code, we're trying to set properties on the undefined argument.
Change History (2)
comment:1 Changed 8 years ago by
Milestone: | tbd → 1.9 |
---|---|
Owner: | set to bill |
Status: | new → assigned |
I see, OK my fault, I'll fix.