Opened 7 years ago

Closed 7 years ago

#16557 closed defect (fixed)

Build broken - ready.js throws undefined error

Reported by: James Thomas Owned by: bill
Priority: undecided Milestone: 1.9
Component: Core Version: 1.8.3
Keywords: Cc:
Blocked By: Blocking:

Description

Running a basic build against trunk falls with the following error:

/Users/james/Code/DTK/current/dojo/ready.js:59

domReady._onQEmpty = onEvent;

TypeError?: Cannot set property '_onQEmpty' of undefined

at /Users/james/Code/DTK/current/dojo/ready.js:59:21 at runFactory (/Users/james/Code/DTK/current/dojo/dojo.js:1094:43) at execModule (/Users/james/Code/DTK/current/dojo/dojo.js:1223:5) at execModule (/Users/james/Code/DTK/current/dojo/dojo.js:1214:12) at execModule (/Users/james/Code/DTK/current/dojo/dojo.js:1214:12) at contextRequire (/Users/james/Code/DTK/current/dojo/dojo.js:789:7) at guardCheckComplete (/Users/james/Code/DTK/current/dojo/dojo.js:1238:5) at contextRequire (/Users/james/Code/DTK/current/dojo/dojo.js:788:6) at req (/Users/james/Code/DTK/current/dojo/dojo.js:124:11) at hasCache.host-browser (/Users/james/Code/DTK/current/dojo/dojo.js:1901:17)

Look at the recent comments, changes to ready.js seem responsible. The domReady dependency is ignored on non-browser platforms but in the code, we're trying to set properties on the undefined argument.

Change History (2)

comment:1 Changed 7 years ago by bill

Milestone: tbd1.9
Owner: set to bill
Status: newassigned

The domReady dependency is ignored on non-browser platforms but in the code, we're trying to set properties on the undefined argument.

I see, OK my fault, I'll fix.

comment:2 Changed 7 years ago by bill

Resolution: fixed
Status: assignedclosed

In [30322]:

Get dojo/ready working on a non-browser environment again, so the builder works. I'm unclear why dojo/ready is getting called at all in that case though. Refs #16389, fixes #16557 !strict

Note: See TracTickets for help on using tickets.