Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#16545 closed defect (fixed)

dojox.form.Uploader - hardcoded names 'dojo' and 'dojox'

Reported by: iamFake Owned by: bill
Priority: undecided Milestone: 1.9
Component: DojoX Uploader Version: 1.8.3
Keywords: Cc:
Blocked By: Blocking:

Description

dojox.form.Uploader module has direct references to dojo (line 126, must be domConstruct) and dojox (must be relative reference, defined in 'define' statement, otherwise you can not use 'pageckMap' with this module)

Change History (11)

comment:1 in reply to:  description Changed 6 years ago by iamFake

i mean packageMap of course

comment:2 Changed 6 years ago by bill

Component: DojoX FormDojoX Uploader
Owner: changed from dante to Mike Wilcox

comment:3 Changed 6 years ago by bill

The two fixes you listed should go in, but it seems more screwed up than that. The code around addUploaderPlugin() relies on dojox.form.Uploader being a global variable in more ways than one. I don't see any easy way to make the plugins work without relying on global variables.

comment:4 Changed 6 years ago by bill

In [30284]:

trivial AMD fixes for dojox/form/Uploader, refs #16545 !strict

comment:5 in reply to:  3 Changed 6 years ago by ben hockey

Replying to bill:

... The code around addUploaderPlugin() relies on dojox.form.Uploader being a global variable in more ways than one. I don't see any easy way to make the plugins work without relying on global variables.

bill, we can probably close this ticket since there are other open tickets for the way plugins work - #16293 and #14811.

these couple of changes should be enough to fix the issues specifically encountered when using packageMap.

comment:6 Changed 6 years ago by bill

Milestone: tbd1.9
Owner: changed from Mike Wilcox to bill
Status: newassigned

I see, I forgot to check for existing tickets. There's still a dojox reference outside of the plugin code, so I'll remove that and then close this ticket.

comment:7 Changed 6 years ago by bill

Resolution: fixed
Status: assignedclosed

In [30287]:

remove remaining direct references to dojox global, fixes #16545 !strict (except that plugin code still doesn't work with AMD).

comment:8 Changed 6 years ago by ben hockey

Resolution: fixed
Status: closedreopened

i'm pretty sure you just broke things... you moved dojox.form.addUploaderPlugin to dojox.form.Uploader.addUploaderPlugin.

comment:9 Changed 6 years ago by ben hockey

Resolution: fixed
Status: reopenedclosed

oh, nevermind... didn't read far enough.

comment:10 Changed 6 years ago by bill

Yeah, I tried to maintain backwards compatibility despite the fact that dojox.form.Uploader should never have been creating a variable named dojox.form.addUploaderPlugin, since that's outside of Uploader's namespace.

comment:11 Changed 6 years ago by bill

In [30333]:

redo AMD conversion apparently accidentally reverted in [30328], refs #16545 !strict

Note: See TracTickets for help on using tickets.