[patch][cla] dojo/request/xhr default overrides specified content-type header

[Brandon Payton]

The default Content-Type in dojo/request/xhr overrides a specified content-type header when the letter casing isn't exactly "Content-Type".

The following sends the default Content-Type 'application/x-www-form-urlencoded' instead of 'application/json':

xhr.post("http://some/url", {
    headers: {
        "content-type": "application/json"
    },
    data: "[]"
})

I have attached patches for a fix and an additional unit test. The unit test required an additional PHP file for dojo/tests/request/, and that is attached as well.

Any feedback is appreciated.

[Brandon Payton]

The patch for dojo/request/xhr.js

[Brandon Payton]

The patch for dojo/tests/request/xhr.html

[Brandon Payton]

An additional supporting .php file to be placed in dojo/tests/request/

[Brandon Payton]

This work is covered by my personal CLA.

[Brandon Payton]

I just realized this patch doesn't add the default Content-Type into response.options.headers. That seems desirable. Let me know what you think, and I can provide another patch and test case to verify the default content-type shows up in response.options.

[dylan]

Bryan,

Please review for consideration as part of 1.9.

[Bryan Forbes]

In [30738]:

Fix content-type casing issues. !strict refs #16532

[Bryan Forbes]

In [30739]:

Fix content-type casing issues (1.8 backport). !strict refs #16532