Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#16526 closed defect (fixed)

[patch][cla] dojo/request/node does not catch handler exceptions

Reported by: Brandon Payton Owned by: Bryan Forbes
Priority: undecided Milestone: 1.8.4
Component: IO Version: 1.8.3
Keywords: Cc:
Blocked By: Blocking:

Description

Exceptions thrown by response handlers are not caught by dojo/request/node.

I've attached patches for a fix and a new unit test. The dojo/tests/request/node module was reworked so the HTTP server created there could accommodate multiple tests.

This work is covered by my personal CLA.

Attachments (2)

dojo-request-node.patch (452 bytes) - added by Brandon Payton 7 years ago.
A patch for dojo/request/node
dojo-tests-request-node.patch (2.3 KB) - added by Brandon Payton 7 years ago.
A patch for dojo/tests/request/node containing a new unit test

Download all attachments as: .zip

Change History (9)

comment:1 Changed 7 years ago by bill

Component: CoreIO
Owner: set to Bryan Forbes

BTW there should be no spaces between a right paren and left curly brace.

Changed 7 years ago by Brandon Payton

Attachment: dojo-request-node.patch added

A patch for dojo/request/node

Changed 7 years ago by Brandon Payton

A patch for dojo/tests/request/node containing a new unit test

comment:2 Changed 7 years ago by Brandon Payton

Ok, thanks. The patches are now updated with that whitespace removed.

comment:3 Changed 7 years ago by dylan

Milestone: tbd1.9

Bryan,

Please review this one for consideration for 1.9.

comment:4 Changed 7 years ago by Bryan Forbes

In [30736]:

Catch handler exceptions in node provider. !strict refs #16526

comment:5 Changed 7 years ago by Bryan Forbes

In [30737]:

Catch handler exceptions in node provider (1.8 backport). !strict refs #16526

comment:6 Changed 7 years ago by Bryan Forbes

Resolution: fixed
Status: newclosed

Nice catch! Thanks for the patch.

comment:7 Changed 7 years ago by bill

Milestone: 1.91.8.4
Note: See TracTickets for help on using tickets.