Opened 7 years ago
Closed 6 years ago
#16520 closed defect (fixed)
dojox.mobile JsHint issues (accidentally created global vars, unused local vars etc.)
| Reported by: | Paul Christopher | Owned by: | Patrick Ruzand |
|---|---|---|---|
| Priority: | high | Milestone: | 1.10 |
| Component: | DojoX Mobile | Version: | 1.8.0 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
I have just anlaysed the code of dojox mobile with JsHint since I have encountered some accidentally created global vars in SpinWheelSlot.js, see http://bugs.dojotoolkit.org/ticket/16519. This is the result:
dojo-release-1.8.0-src\dojox\mobile\Carousel.js: line 271, col 17, 'pg' is not defined.
dojo-release-1.8.0-src\dojox\mobile\CarouselItem.js: line 68, col 37, Missing semicolon.
dojo-release-1.8.0-src\dojox\mobile\common.js: line 110, col 20, 'outerHeight' is not defined.
dojo-release-1.8.0-src\dojox\mobile\common.js: line 110, col 34, 'devicePixelRatio' is not defined.
dojo-release-1.8.0-src\dojox\mobile\common.js: line 119, col 24, 'innerHeight' is not defined.
dojo-release-1.8.0-src\dojox\mobile\common.js: line 134, col 16, 'pageYOffset' is not defined.
dojo-release-1.8.0-src\dojox\mobile\dh\DataHandler.js: line 53, col 20, Missing semicolon.
dojo-release-1.8.0-src\dojox\mobile\dh\HtmlContentHandler.js: line 45, col 21, 'i' is not defined.
dojo-release-1.8.0-src\dojox\mobile\dh\HtmlContentHandler.js: line 45, col 28, 'len' is not defined.
dojo-release-1.8.0-src\dojox\mobile\Heading.js: line 23, col 11, 'dm' is defined but never used.
dojo-release-1.8.0-src\dojox\mobile\IconMenu.js: line 98, col 32, 'w' used out of scope.
dojo-release-1.8.0-src\dojox\mobile\IconMenu.js: line 98, col 44, '_w' used out of scope.
dojo-release-1.8.0-src\dojox\mobile\IconMenu.js: line 99, col 33, 'h' used out of scope.
dojo-release-1.8.0-src\dojox\mobile\IconMenu.js: line 99, col 54, 'nRows' used out of scope.
dojo-release-1.8.0-src\dojox\mobile\IconMenu.js: line 99, col 63, '_h' used out of scope.
dojo-release-1.8.0-src\dojox\mobile\IconMenu.js: line 104, col 99, 'nRows' used out of scope.
dojo-release-1.8.0-src\dojox\mobile\IconMenu.js: line 106, col 14, Unnecessary semicolon.
dojo-release-1.8.0-src\dojox\mobile\iconUtils.js: line 27, col 87, Missing semicolon.
dojo-release-1.8.0-src\dojox\mobile\iconUtils.js: line 99, col 22, Missing semicolon.
dojo-release-1.8.0-src\dojox\mobile\lazyLoadUtils.js: line 90, col 10, Missing semicolon.
dojo-release-1.8.0-src\dojox\mobile\lazyLoadUtils.js: line 23, col 35, 's' is defined but never used.
dojo-release-1.8.0-src\dojox\mobile\ListItem.js: line 306, col 22, Missing semicolon.
dojo-release-1.8.0-src\dojox\mobile\migrationAssist.js: line 316, col 5, 'extendSelectFunction' is not defined.
dojo-release-1.8.0-src\dojox\mobile\pageTurningUtils.js: line 103, col 111, Missing semicolon.
dojo-release-1.8.0-src\dojox\mobile\pageTurningUtils.js: line 128, col 21, Variable fold was not declared correctly.
dojo-release-1.8.0-src\dojox\mobile\pageTurningUtils.js: line 392, col 119, Missing semicolon.
dojo-release-1.8.0-src\dojox\mobile\pageTurningUtils.js: line 573, col 57, Unnecessary semicolon.
dojo-release-1.8.0-src\dojox\mobile\pageTurningUtils.js: line 482, col 30, 'pages' is defined but never used.
dojo-release-1.8.0-src\dojox\mobile\Slider.js: line 76, col 28, 'fromPercent' is defined but never used.
dojo-release-1.8.0-src\dojox\mobile\Slider.js: line 83, col 27, 'horizontal' is defined but never used.
dojo-release-1.8.0-src\dojox\mobile\ToolBarButton.js: line 144, col 14, Missing semicolon.
dojo-release-1.8.0-src\dojox\mobile\TreeView.js: line 50, col 14, Missing semicolon.
dojo-release-1.8.0-src\dojox\mobile\TreeView.js: line 107, col 14, Missing semicolon.
dojo-release-1.8.0-src\dojox\mobile\TreeView.js: line 40, col 29, 'node' is defined but never used.
dojo-release-1.8.0-src\dojox\mobile\ValuePickerSlot.js: line 82, col 21, 'i' is not defined.
dojo-release-1.8.0-src\dojox\mobile\View.js: line 28, col 11, 'dm' is defined but never used.
dojo-release-1.8.0-src\dojox\mobile\_EditableIconMixin.js: line 299, col 25, 'j' is not defined.
Attachments (1)
Change History (6)
Changed 7 years ago by
| Attachment: | JsHintReport.txt added |
|---|
comment:1 Changed 7 years ago by
| Owner: | changed from Eric Durocher to Patrick Ruzand |
|---|---|
| Status: | new → assigned |
comment:2 Changed 6 years ago by
| Milestone: | tbd → 1.10 |
|---|
comment:3 Changed 6 years ago by
| Priority: | undecided → high |
|---|
comment:4 Changed 6 years ago by
comment:5 Changed 6 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
PR submitted here: https://github.com/dojo/dojox/pull/91