SpinWheelSlot accidentally creates global variables "i" and "j" / has an unused local variable "a" / uses an undefined property "nDays"

[Paul Christopher]

• In "buildRendering", SpinWheelSlot creates two global variables i,j.

• Function "adjustDestination" has an unused local variable "a".

• Line 215: "nDays" is not defined. Should be "n"?

[Adrian Vasiliu]

Fixed unintended global variables, unused variable, and wrong implementation of disableValues() - Paul Christopher, CLA and Adrian Vasiliu, IBM, CCLA

[Adrian Vasiliu]

Good catches, thanks Paul. My attached patch16519.patch is strongly inspired from yours, however for disableValues() I also modified the code (and API doc) to make it generic and avoid that it throws an exception when the slot contains less than 28 items (in other words, when it is not used for showing the days of the month). That said, I guess the real purpose of the method is to be only called internally for calendar slots. Also included in my patch a DOH test case for disableValues().

[cjolif]

In [30294]:

Fixes #16519. Unintended global variables, unused variable, and wrong implementation of disableValues() - Thanks Paul Christopher (CLA) and Adrian Vasiliu (IBM, CCLA).