#16519 closed defect (fixed)
SpinWheelSlot accidentally creates global variables "i" and "j" / has an unused local variable "a" / uses an undefined property "nDays"
Reported by: | Paul Christopher | Owned by: | Eric Durocher |
---|---|---|---|
Priority: | undecided | Milestone: | 1.9 |
Component: | DojoX Mobile | Version: | 1.8.0 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
- In "buildRendering", SpinWheelSlot creates two global variables i,j.
- Function "adjustDestination" has an unused local variable "a".
- Line 215: "nDays" is not defined. Should be "n"?
Attachments (2)
Change History (5)
Changed 8 years ago by
Attachment: | SpinWheelSlot.js.patch added |
---|
Changed 8 years ago by
Attachment: | patch16519.patch added |
---|
comment:1 Changed 8 years ago by
Good catches, thanks Paul. My attached patch16519.patch is strongly inspired from yours, however for disableValues() I also modified the code (and API doc) to make it generic and avoid that it throws an exception when the slot contains less than 28 items (in other words, when it is not used for showing the days of the month). That said, I guess the real purpose of the method is to be only called internally for calendar slots. Also included in my patch a DOH test case for disableValues().
comment:3 Changed 8 years ago by
Milestone: | tbd → 1.9 |
---|
Note: See
TracTickets for help on using
tickets.
Fixed unintended global variables, unused variable, and wrong implementation of disableValues() - Paul Christopher, CLA and Adrian Vasiliu, IBM, CCLA